Gerrit

*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************

What steps will reproduce the problem?
1. Import accounts from other servers with different GerritServerId
2. Hit the GET /accounts/{id}/detail to get details about the user

What is the expected output?

The endpoint returns 404

What do you see instead?

The endpoint returns 200

Please provide any additional information below.

This is also visible in the UI, whereby if a change was commented upon by an imported user, the anonymousCoward name is used instead.

When rendering the user details associated to a comment, the an ajax call is made to the /accounts/{id}/detail endpoint with the user that is stored in the change metadata.

An example of how such data is stored in notedb is:

commit 1596cb7b8a5d3292aca43b9f93b4aa2ff0b0ac50 (refs/changes/94/202394/meta)  
Author: Gerrit User 97483 <97483@97ee7c02-f12f-4043-b43e-dea463d88b31>  
Date:   Wed Jun 7 21:02:50 2023 -0400  
  
    Update patch set 4  
  
    Patch Set 4:  
  
    (4 comments)  
  
    Patch-set: 4  
    Attention: {"person_ident":"Gerrit User 97483 \u003c97483@97ee7c02-f12f-4043-b43e-dea463d88b31\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_97483\u003e replied on the change"}  
    Attention: {"person_ident":"Gerrit User 4 \u003c4@97ee7c02-f12f-4043-b43e-dea463d88b31\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_97483\u003e replied on the change"}  

So the UI makes the following requests:

GET https://review.gerrithub.io/accounts/97483/detail
GET https://review.gerrithub.io/accounts/4/detail

Both of them returns 404 because such users do not exist in GerritHub.

This change [1] introduced the ability to resolve accounts by imported externalId, but it was just applied to the parsing of NoteDb, whilst the REST API is still unaware of imported accounts.

I believe the accounts/{id}/detail endpoint, before returning 404, should check whether there is any user linked to the imported identity ( imported:97483 and imported:4), lookup for the user and return the detail of that one.

[1]https://gerrit-review.googlesource.com/c/gerrit/+/340014