Gerrit home page renders badly on Safari 14.1.2 [40015537]

Obsolete

Bug

Triaged-No

Status Update

No update yet.

Description

lu...@gmail.com

created issue #1

May 13, 2023 01:48PM

*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************

What steps will reproduce the problem?
1. Start gerrit v3.8.0-rc5 and login

What is the expected output?
The Gerrit home page is rendered without issues with Safari Version 14.1.2 (14611.3.10.1.7)

What do you see instead?
The Gerrit home page is rendered with formatting issues

Please provide any additional information below.
I see these errors on the JS console:
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (index.html, line 0)
[Error] TypeError: this.registrationModal.showModal is not a function. (In 'this.registrationModal.showModal()', 'this.registrationModal.showModal' is undefined)
(anonymous function) — gr-app.js:24212:2096406
asyncFunctionResume
[native code]
promiseReactionJobWithoutPromise

reporter (gr-app.js:1:145783)  
error (gr-app.js:1:151980)  
(anonymous function) (gr-app.js:1:143190)

[Error] Unhandled Promise Rejection: TypeError: this.registrationModal.showModal is not a function. (In 'this.registrationModal.showModal()', 'this.registrationModal.showModal' is undefined)
(anonymous function) (gr-app.js:24212:2096406)
asyncFunctionResume
(anonymous function)
promiseReactionJobWithoutPromise

Selected Element
< <div class="header" slot="header">An error occurred</div>

Comments

th...@yahoo.com <th...@yahoo.com> #2May 13, 2023 02:53PM

https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/showModal says showModel is only on 15.4+. There's this polyfill tho

https://github.com/niutech/showModalDialog.

th...@yahoo.com <th...@yahoo.com> #3May 13, 2023 03:06PM

Hmm maybe that polyfill wouldn't work. Maybe it needs

https://github.com/GoogleChrome/dialog-polyfill ?

is...@google.com <is...@google.com> #4May 13, 2023 03:06PM

Edits were made to reflect the following in Monorail: auto-CCs.

ap...@google.com <ap...@google.com> #5Nov 14, 2023 09:34AM

Project: homepage
Branch: master

commit d1b83778666008a990a049172fb292d1c0b4518b
Author: Luca Milanesio <luca.milanesio@gmail.com>
Date: Tue Nov 07 20:36:24 2023

Highlight known-issues on Gerrit v3.8

Gerrit v3.8 has been shipped with two known critical issues:
- Change 360646, caused a radical change in the way Gerrit threads
are handling the updates of the ref-database, leading to potential
corruption in multi-site and concurrent GCs
-

Issue 40015537

, causing Gerrit to render a complete blank page on
certain browsers that have been working fine until v3.7.x

Introduce the "Known issues" section, visually close to the
"Breaking changes" to warn the Gerrit administrator about the potential
breakages that he may encounter when migrating to Gerrit v3.8.x.

The Gerrit administrator can therefore make the necessary adjustments to
the environment and client browsers for preventing the known issues to
impact the users after the upgrade.

Bug:

Issue 309098227

Bug:

Issue 40015537

Change-Id: I83d7dc34563e381a8b6b7bb82ec820063cc0e16b

M pages/site/releases/

3.8.md

https://gerrit-review.googlesource.com/392082

ek...@google.com <ek...@google.com> #6Nov 13, 2024 11:48AM

Start gerrit v3.8.0-rc5 and login

Does the same happen on master?

The Gerrit home page is rendered with formatting issues

Could you please attach a screenshot? How bad are the formatting issues (UI is unusable vs. there are some glitches that would be nice to fix)?

ek...@google.com <ek...@google.com> #7Nov 13, 2024 11:48AM

Assigned to lu...@gmail.com.

Please unassign from the issue after replying.

lu...@gmail.com <lu...@gmail.com> #8Nov 13, 2024 01:53PM

Status: Won't Fix (Obsolete)

I did not receive any further complains about Safari 14.1.2, which was included in MacOS Big Sur.

MacOS Big Sur is unsupported as of September 26, 2023, therefore we do not have to support Safari 14.x anymore IMHO.

lu...@gmail.com <lu...@gmail.com> #9Nov 13, 2024 01:54PM

Setting this issue as obsolete, as the Safari version associated is EOL.

th...@yahoo.com <th...@yahoo.com> #10Nov 13, 2024 02:00PM

Safari 14 doesn't support the dialog element. Only 15.4+ does, see https://caniuse.com/dialog.

Issue 40015537

Description

Issue summary

Comments

th...@yahoo.com <th...@yahoo.com> #2May 13, 2023 02:53PM

th...@yahoo.com <th...@yahoo.com> #3May 13, 2023 03:06PM

is...@google.com <is...@google.com> #4May 13, 2023 03:06PM

ap...@google.com <ap...@google.com> #5Nov 14, 2023 09:34AM

ek...@google.com <ek...@google.com> #6Nov 13, 2024 11:48AM

ek...@google.com <ek...@google.com> #7Nov 13, 2024 11:48AM

lu...@gmail.com <lu...@gmail.com> #8Nov 13, 2024 01:53PM

lu...@gmail.com <lu...@gmail.com> #9Nov 13, 2024 01:54PM

th...@yahoo.com <th...@yahoo.com> #10Nov 13, 2024 02:00PM

Add comment

Issue metadata