In Progress
Status Update
Comments
ly...@gmail.com <ly...@gmail.com> #2
This is a 3.7.0 regression.
3.6.3 does not have this problem.
3.6.3 does not have this problem.
ly...@gmail.com <ly...@gmail.com> #4
Looks like whatever gets created in createLinkTemplate is not correctly handled afterwards.
ly...@gmail.com <ly...@gmail.com> #5
Also, getBaseUrl needs “window” to be set, otherwise it returns an empty string.
pr...@pacbell.net <pr...@pacbell.net> #6
We just migrated to 3.7.1 and this is #1 user complaint, can we get this fixed please
rf...@gmail.com <rf...@gmail.com> #7
Migrated to 3.7.2 from 3.6.1 and even the example in the documentation doesn't work anymore
[commentlink "changeid"]
match = (I[0-9a-f]{8,40})
link = "#/q/$1"
Pressing on the link produced brings you back to the same change you are at, no matter what changeid is actually used.
We used that for dependency management on other changeids.
[commentlink "changeid"]
match = (I[0-9a-f]{8,40})
link = "#/q/$1"
Pressing on the link produced brings you back to the same change you are at, no matter what changeid is actually used.
We used that for dependency management on other changeids.
br...@google.com <br...@google.com> #8
Just drop the # from the link. I will update the docs. Sorry.
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/3f9924a8ed48ca16f2e70bf8cdc6924a846c8352
commit 3f9924a8ed48ca16f2e70bf8cdc6924a846c8352
Author: Ben Rohlfs <brohlfs@google.com>
Date: Wed May 17 06:41:20 2023
Update commentlink example in the docs
Remove the # from the link.
Release-Notes: skip
Bug:https://crbug.com/gerrit/16745
Change-Id: If33813d2e46af0b4cb201fa383581c0c34b73de7
[modify]https://gerrit.googlesource.com/gerrit/+/3f9924a8ed48ca16f2e70bf8cdc6924a846c8352/Documentation/config-gerrit.txt
commit 3f9924a8ed48ca16f2e70bf8cdc6924a846c8352
Author: Ben Rohlfs <brohlfs@google.com>
Date: Wed May 17 06:41:20 2023
Update commentlink example in the docs
Remove the # from the link.
Release-Notes: skip
Bug:
Change-Id: If33813d2e46af0b4cb201fa383581c0c34b73de7
[modify]
rf...@gmail.com <rf...@gmail.com> #10
Hi.
I have removed the # as suggested by your update, but now we get different behavior.
Before the change, pressing on Change-Id link took us directly to the change.
Now we get to a search result with only one entry, and we need to click on it to get to the change page.
Thanks,
Ramon
I have removed the # as suggested by your update, but now we get different behavior.
Before the change, pressing on Change-Id link took us directly to the change.
Now we get to a search result with only one entry, and we need to click on it to get to the change page.
Thanks,
Ramon
br...@google.com <br...@google.com> #11
Patrick, can you have a look. I cannot repro on master.
is...@google.com <is...@google.com> #12
Edits were made to reflect the following in Monorail: auto-CCs.
th...@yahoo.com <th...@yahoo.com> #13
I can reproduce on 3.7 but not on master.
th...@yahoo.com <th...@yahoo.com> #14
th...@yahoo.com <th...@yahoo.com> #15
ap...@google.com <ap...@google.com> #18
Project: gerrit
Branch: stable-3.7
commit 45b980be931a3e572d295a68d713c9de32b59772
Author: Chris Poucet <poucet@google.com>
Date: Fri Feb 10 16:06:55 2023
Always default linkify regular URLs prefixed with https?://
Bug: Issue 40015399
Release-Notes: We removed automatic linkification of URLs that do not
start with https?://
Change-Id: Ib85f19a42156a27c2c87c52430ea8a53e5717789
M polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text_test.ts
M polygerrit-ui/app/utils/link-util.ts
M polygerrit-ui/app/utils/link-util_test.ts
https://gerrit-review.googlesource.com/378075
Branch: stable-3.7
commit 45b980be931a3e572d295a68d713c9de32b59772
Author: Chris Poucet <poucet@google.com>
Date: Fri Feb 10 16:06:55 2023
Always default linkify regular URLs prefixed with https?://
Bug:
Release-Notes: We removed automatic linkification of URLs that do not
start with https?://
Change-Id: Ib85f19a42156a27c2c87c52430ea8a53e5717789
M polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text_test.ts
M polygerrit-ui/app/utils/link-util.ts
M polygerrit-ui/app/utils/link-util_test.ts
ap...@google.com <ap...@google.com> #19
Project: gerrit
Branch: stable-3.7
commit d4c494b311eaf928fe8ae19aba937de2347b077e
Author: Chris Poucet <poucet@google.com>
Date: Wed Feb 08 10:31:07 2023
Get rid of ba-linkify.
We've had multiple complaints about linkification. markdown already
linkifies explicit links and we have rewrite rules.
Bug: Issue 40015399
Release-Notes: skip
Change-Id: I65caafbab8b063a22e85401832977b6afb5705bb
M Documentation/js_licenses.txt
M Documentation/licenses.txt
M polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text_test.ts
M polygerrit-ui/app/node_modules_licenses/licenses.ts
M polygerrit-ui/app/package.json
M polygerrit-ui/app/utils/link-util.ts
M polygerrit-ui/app/utils/link-util_test.ts
M polygerrit-ui/app/yarn.lock
https://gerrit-review.googlesource.com/378074
Branch: stable-3.7
commit d4c494b311eaf928fe8ae19aba937de2347b077e
Author: Chris Poucet <poucet@google.com>
Date: Wed Feb 08 10:31:07 2023
Get rid of ba-linkify.
We've had multiple complaints about linkification. markdown already
linkifies explicit links and we have rewrite rules.
Bug:
Release-Notes: skip
Change-Id: I65caafbab8b063a22e85401832977b6afb5705bb
M Documentation/js_licenses.txt
M Documentation/licenses.txt
M polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text_test.ts
M polygerrit-ui/app/node_modules_licenses/licenses.ts
M polygerrit-ui/app/package.json
M polygerrit-ui/app/utils/link-util.ts
M polygerrit-ui/app/utils/link-util_test.ts
M polygerrit-ui/app/yarn.lock
Description
Affected Version: 3.7.0
What steps will reproduce the problem?
1. Add "foo://bar.baz" to the commit message
2. Observe the link to "about:
What is the expected output?
Either having it rendered it as plain text (this is what 3.5.3 does), or <a href="foo://bar.baz/> (which is arguably less secure).
What do you see instead?
<a href="about:invalid#zClosurez" rel="noopener" target="_blank">foo://bar.baz</a>
What is the output of the JS console log (if applicable)?
nothing interesting
What is the performance record (seehttps://developers.google.com/web/tools
/chrome-devtools/evaluate-performance/reference#record)(if applicable)?
nothing interesting
Please provide any additional information below.
This prevents us from using this section:
[commentlink "radar"]
match = \b(1?[0-9]{7,8})\b
link = foo://problem/$1
which worked fine in 3.5.3.