Verified
Status Update
Comments
[Deleted User] <[Deleted User]> #2
Note that the version I experienced this issue in was Gerrit 3.5.3
tv...@gmail.com <tv...@gmail.com> #3
[Comment Deleted]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/010fa0b4375601c19bb70b30d7793bfb5a7f8859
commit 010fa0b4375601c19bb70b30d7793bfb5a7f8859
Author: Darius Jokilehto <dariusjokilehto+os@gmail.com>
Date: Mon Feb 06 16:39:39 2023
Fix parsing legacy labels for users with comma
This change fixes a bug introduced by change 336883 when parsing labels
where a UUID was present together with a user name containing a comma.
Bug:https://crbug.com/gerrit/16529
Release-Notes: Fix parsing legacy labels for users with comma
Forward-Compatible: checked
Change-Id: I32575d11dadc2cbe82ae78ff1f43186ba730d611
[modify]https://gerrit.googlesource.com/gerrit/+/010fa0b4375601c19bb70b30d7793bfb5a7f8859/javatests/com/google/gerrit/server/notedb/ChangeNotesParserTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/010fa0b4375601c19bb70b30d7793bfb5a7f8859/java/com/google/gerrit/server/notedb/ChangeNotesParser.java
commit 010fa0b4375601c19bb70b30d7793bfb5a7f8859
Author: Darius Jokilehto <dariusjokilehto+os@gmail.com>
Date: Mon Feb 06 16:39:39 2023
Fix parsing legacy labels for users with comma
This change fixes a bug introduced by change 336883 when parsing labels
where a UUID was present together with a user name containing a comma.
Bug:
Release-Notes: Fix parsing legacy labels for users with comma
Forward-Compatible: checked
Change-Id: I32575d11dadc2cbe82ae78ff1f43186ba730d611
[modify]
[modify]
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. re-index changes where users with a comma inside the user id are appearing
What is the expected output?
Re-indexing of changes should be behaving normally and index all changes without errors
What do you see instead?
The user ids are being cut off after a comma inside their name strings and the following error appears:
Please provide any additional information below.
further errors regarding that topic:
as visible here the input string is being cut exactly where the comma in the users id was.