Bug P1
Status Update
No update yet.
Comments
lu...@gmail.com
Project.config:
[2022-05-16 10:08:13,732] [main] INFO com.google.gerrit.server.config.ScheduleConfig : No schedule configuration for "changeCleanup".
[access]
inheritFrom = All-Projects
[submit]
action = inherit
[label "Verified"]
function = MaxWithBlock
value = -1 Fails
value = 0 No score
value = +1 Verified
copyCondition = has:unchanged-files
defaultValue = 0
[access "refs/*"]
label-Code-Review = -2..+2 group Registered Users
label-Verified = -1..+1 group Registered Users
All-Projects / project.config
[label "Code-Review"]
function = MaxWithBlock
defaultValue = 0
copyMinScore = true
copyAllScoresOnTrivialRebase = true
value = -2 This shall not be merged
value = -1 I would prefer this is not merged as is
value = 0 No score
value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me, approved
[2022-05-16 10:08:13,732] [main] INFO com.google.gerrit.server.config.ScheduleConfig : No schedule configuration for "changeCleanup".
[access]
inheritFrom = All-Projects
[submit]
action = inherit
[label "Verified"]
function = MaxWithBlock
value = -1 Fails
value = 0 No score
value = +1 Verified
copyCondition = has:unchanged-files
defaultValue = 0
[access "refs/*"]
label-Code-Review = -2..+2 group Registered Users
label-Verified = -1..+1 group Registered Users
All-Projects / project.config
[label "Code-Review"]
function = MaxWithBlock
defaultValue = 0
copyMinScore = true
copyAllScoresOnTrivialRebase = true
value = -2 This shall not be merged
value = -1 I would prefer this is not merged as is
value = 0 No score
value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me, approved
lu...@gmail.com
NoteDb:
commit 54ad559e86a84b6195f13d18be4c1e0eab8ec28a (refs/changes/22/22/meta)
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:50:49 2022 +0000
Create patch set 5
Patch Set 5: Patch Set 4 was rebased
Patch-set: 5
Patch-set-description: Rebase
Subject: bar 2 3
Commit: 18054b76b167bebaf6b4d991e142fd73a819079a
Tag: autogenerated:gerrit:newPatchSet
Groups: ad8e8e2242b24b1ee1e643bf9fbf1031525e6325
commit 867b0123e3f00cd0558d74f1e53bc509c6b99c78
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:50:18 2022 +0000
Update patch set 4
Patch Set 4: Verified+1 Code-Review+2
Patch-set: 4
Reviewer: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Label: Code-Review=+2
Label: Verified=+1
commit 122b79d45bb7b17b9e1427760a67f72d098858cf
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:48:12 2022 +0000
Create patch set 4
Patch Set 4: Commit message was updated.
Patch-set: 4
Patch-set-description: Edit commit message
Subject: bar 2 3
Commit: 44e6e063ff9fb629022fa3679aa71e40b82583cd
Tag: autogenerated:gerrit:newPatchSet
Groups: ad8e8e2242b24b1ee1e643bf9fbf1031525e6325
commit 54ad559e86a84b6195f13d18be4c1e0eab8ec28a (refs/changes/22/22/meta)
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:50:49 2022 +0000
Create patch set 5
Patch Set 5: Patch Set 4 was rebased
Patch-set: 5
Patch-set-description: Rebase
Subject: bar 2 3
Commit: 18054b76b167bebaf6b4d991e142fd73a819079a
Tag: autogenerated:gerrit:newPatchSet
Groups: ad8e8e2242b24b1ee1e643bf9fbf1031525e6325
commit 867b0123e3f00cd0558d74f1e53bc509c6b99c78
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:50:18 2022 +0000
Update patch set 4
Patch Set 4: Verified+1 Code-Review+2
Patch-set: 4
Reviewer: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Label: Code-Review=+2
Label: Verified=+1
commit 122b79d45bb7b17b9e1427760a67f72d098858cf
Author: Gerrit User 1000000 <1000000@739be275-df34-4bd3-9993-7d2b64fe0dd3>
Date: Mon May 16 09:48:12 2022 +0000
Create patch set 4
Patch Set 4: Commit message was updated.
Patch-set: 4
Patch-set-description: Edit commit message
Subject: bar 2 3
Commit: 44e6e063ff9fb629022fa3679aa71e40b82583cd
Tag: autogenerated:gerrit:newPatchSet
Groups: ad8e8e2242b24b1ee1e643bf9fbf1031525e6325
lu...@gmail.com
[Empty comment from Monorail migration]
da...@gmail.com
[Monorail components: Backend NoteDb]
lu...@gmail.com
Gerrit v3.5 behaves like v3.4: hence the bug is in v3.6 with or without Patrick's tool [2].
(see screenshot)
(see screenshot)
da...@gmail.com
[Empty comment from Monorail migration]
lu...@gmail.com
It works with @Davido fix ! (see screenshot)
ek...@google.com
[Monorail components: -NoteDb]
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. Create a project with sticky labels on Gerrit v3.4
2. Create a change and give +2
3. Rebase the change
What is the expected output?
The +2 is sticky in v3.4 and, after the upgrade, is still sticky.
What do you see instead?
The +2 in v3.4 is lost after upgrading to v3.5
Please provide any additional information below.
This is expected after the merge of [1] on v3.6. I tried to run Patrick's change [2] for generating the copied label on v3.6 but the result obtained is not the same one observed in v3.4.
See attached:
[1]https://gerrit-review.googlesource.com/c/gerrit/+/323897 https://gerrit-review.googlesource.com/c/gerrit/+/337054
[2]