Assigned
Status Update
Comments
lu...@gmail.com <lu...@gmail.com> #2
[Empty comment from Monorail migration]
lu...@gmail.com <lu...@gmail.com> #3
The main features are shown on the main index of the home page. Should the about page include the same information that is there, or be more detailed?
da...@gmail.com <da...@gmail.com> #4
I would say more details. Alternatively we could just rename it to "Project History" and move it to a less prominent place.
da...@gmail.com <da...@gmail.com> #5
[Monorail components: Homepage]
da...@gmail.com <da...@gmail.com> #6
[Monorail components: Documentation]
da...@gmail.com <da...@gmail.com> #7
[Monorail components: -docs]
da...@gmail.com <da...@gmail.com> #8
[Empty comment from Monorail migration]
hi...@google.com <hi...@google.com> #9
> The fix should be pretty easy: just ignore in stable-3.5 (also 3.4, 3.3?) whatever is after the ','.
+1
This problem is something we are trying to address more systematically at the moment. Youssef is working on that.
+1
This problem is something we are trying to address more systematically at the moment. Youssef is working on that.
ma...@google.com <ma...@google.com> #11
Talking about problematic changes
1) Aslo this change also adds the backwards incompatible NoteDb modification.
https://gerrit-review.googlesource.com/c/gerrit/+/328617
It is compatible with this change in release:https://gerrit-review.googlesource.com/c/gerrit/+/328616
2) This changehttps://gerrit-review.googlesource.com/c/gerrit/+/328616
introduces the incompatibility in caches
Fixed byhttps://gerrit-review.googlesource.com/c/gerrit/+/335704
As for original change, I can produce a fix to ignore UUID, if you could cherry-pick it to older releases.
1) Aslo this change also adds the backwards incompatible NoteDb modification.
It is compatible with this change in release:
2) This change
introduces the incompatibility in caches
Fixed by
As for original change, I can produce a fix to ignore UUID, if you could cherry-pick it to older releases.
da...@gmail.com <da...@gmail.com> #12
> As for original change, I can produce a fix to ignore UUID, if you could cherry-pick it to older releases.
Thanks, this would be really helpful. Could you push a change to ignore UUID part to stable-3.5 branch?
I could move/cherry-pick that change to stable-3.3 branch. This is the oldest release line that is still supported.
Thanks, this would be really helpful. Could you push a change to ignore UUID part to stable-3.5 branch?
I could move/cherry-pick that change to stable-3.3 branch. This is the oldest release line that is still supported.
ma...@google.com <ma...@google.com> #13
ek...@google.com <ek...@google.com> #14
[Monorail components: -NoteDb]
ja...@instructure.com <ja...@instructure.com> #15
[Comment Deleted]
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. Setup Gerrit v3.5.0 in HA
2. Upgrade one node to v3.6.0
3. Leave the traffic coming to the first node
4. Upgrade the second node to v3.6.0
What is the expected output?
The upgrade process works, as it has always been since v3.0 onwards.
What do you see instead?
The changes created/modified after point 2. are failing on the second node running v3.5.0 with:
com.google.gerrit.exceptions.StorageException: java.io.IOException: Error loading refs/changes/68/537968/meta in <REDACTED> at cbcbc82cf5fa779c3a28ed795c6f74aacc5f3f85
Caused by: org.eclipse.jgit.errors.ConfigInvalidException: Change 537968: invalid Label: Code-Review=+2, 5246e1c862311e995a690d961877176f32941954
at com.google.gerrit.server.notedb.ChangeNotes.parseException(ChangeNotes.java:100)
at com.google.gerrit.server.notedb.ChangeNotesParser.parseException(ChangeNotesParser.java:1279)
Please provide any additional information below.