Verified
Status Update
Comments
ek...@google.com <ek...@google.com> #2
[Monorail components: Backend]
ek...@google.com <ek...@google.com> #3
[Monorail components: -Backend>change-edits]
ap...@google.com <ap...@google.com> #4
Project: gerrit
Branch: stable-3.6
commit 72dd04f7da9a89f89f34eb1f5774d3ca8f318b45
Author: Marcin Czech <maczech@gmail.com>
Date: Tue Nov 21 14:13:21 2023
Fire `ref-updated` stream events on online edit refs update
During the online edit `refs/users/xx/xxxxxxx/edit-x/x` ref is
created and removed when edit is published or deleted.
Make sure all `refs/users/xx/xxxxxxx/edit-x/x` updates generate
`ref-updated` stream events.
Release-Notes: Generate `ref-updated` stream events from online edits
Bug: Issue 40014568
Change-Id: I34192259b7092dab215d7a78e3b59f6a5f15cc71
M java/com/google/gerrit/server/edit/ChangeEditModifier.java
M java/com/google/gerrit/server/edit/ChangeEditUtil.java
https://gerrit-review.googlesource.com/393937
Branch: stable-3.6
commit 72dd04f7da9a89f89f34eb1f5774d3ca8f318b45
Author: Marcin Czech <maczech@gmail.com>
Date: Tue Nov 21 14:13:21 2023
Fire `ref-updated` stream events on online edit refs update
During the online edit `refs/users/xx/xxxxxxx/edit-x/x` ref is
created and removed when edit is published or deleted.
Make sure all `refs/users/xx/xxxxxxx/edit-x/x` updates generate
`ref-updated` stream events.
Release-Notes: Generate `ref-updated` stream events from online edits
Bug:
Change-Id: I34192259b7092dab215d7a78e3b59f6a5f15cc71
M java/com/google/gerrit/server/edit/ChangeEditModifier.java
M java/com/google/gerrit/server/edit/ChangeEditUtil.java
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. Edit one change using on-line edit
2. Save the edit
3. Publish the edit
What is the expected output?
After the action 2. Gerrit invoke the GitReferenceUpdatedListener with the create of refname = refs/users/00/<user-id>/edit-<edit-num>/<patch-set>
After the action 3. Gerrit invokes the GitReferenceUpdatedListener with the delete of refname = refs/users/00/<user-id>/edit-<edit-num>/<patch-set>
What do you see instead?
The create event IS NOT triggered, but the delete event IS triggered.
Please provide any additional information below.