Fixed
Status Update
Comments
lu...@gmail.com <lu...@gmail.com> #2
As an immediate workaround, we have disabled the performance metrics altogether:
[plugin "metrics-reporter-foo"]
excludeMetrics = performance/.*
This should be probably documented in Documentation/metrics.txt and also referred in the release notes.
Another approach could be disabling them by default.
@Edwin did you guys had any issues in the metrics explosion?
[plugin "metrics-reporter-foo"]
excludeMetrics = performance/.*
This should be probably documented in Documentation/metrics.txt and also referred in the release notes.
Another approach could be disabling them by default.
@Edwin did you guys had any issues in the metrics explosion?
ek...@google.com <ek...@google.com> #3
> @Edwin did you guys had any issues in the metrics explosion?
We did, but for us [1] fixed it.
> Another approach could be disabling them by default.
Doing this would be fine with me.
[1]https://gerrit-review.googlesource.com/c/gerrit/+/320978
We did, but for us [1] fixed it.
> Another approach could be disabling them by default.
Doing this would be fine with me.
[1]
lu...@gmail.com <lu...@gmail.com> #4
[1] is already included in our setup: possibly they are still too many :-(
>> Another approach could be disabling them by default.
> Doing this would be fine with me.
+1
[1]https://gerrit-review.googlesource.com/c/gerrit/+/320978
>> Another approach could be disabling them by default.
> Doing this would be fine with me.
+1
[1]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/05bb40334340e48e06914f716575f9aac654aaec
commit 05bb40334340e48e06914f716575f9aac654aaec
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Tue Jan 18 13:37:26 2022
Disable performance metrics by default
Performance metrics were introduced in 3.5 [1].
This caused 10X increse of metrics, for example,
when upgrading from 3.4 to 3.5.
Disabling it by default to avoid an unexpected 10X increase
of metrics payload, which could lead to an increase of latency
when returning it.
[1]:https://gerrit-review.googlesource.com/c/gerrit/+/318346
Bug:https://crbug.com/gerrit/15531
Change-Id: I84f754b1496af43befcdb3624921d8fbb513e7ac
[modify]https://gerrit.googlesource.com/gerrit/+/05bb40334340e48e06914f716575f9aac654aaec/Documentation/config-gerrit.txt
[modify]https://gerrit.googlesource.com/gerrit/+/05bb40334340e48e06914f716575f9aac654aaec/java/com/google/gerrit/server/config/GerritGlobalModule.java
[modify]https://gerrit.googlesource.com/gerrit/+/05bb40334340e48e06914f716575f9aac654aaec/Documentation/metrics.txt
commit 05bb40334340e48e06914f716575f9aac654aaec
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Tue Jan 18 13:37:26 2022
Disable performance metrics by default
Performance metrics were introduced in 3.5 [1].
This caused 10X increse of metrics, for example,
when upgrading from 3.4 to 3.5.
Disabling it by default to avoid an unexpected 10X increase
of metrics payload, which could lead to an increase of latency
when returning it.
[1]:
Bug:
Change-Id: I84f754b1496af43befcdb3624921d8fbb513e7ac
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337
commit c5fcca0dfafe309099ffb8f0adabbed094ed4337
Author: Sven Selberg <svense@axis.com>
Date: Fri Apr 22 11:37:53 2022
Make tracing.performanceLogging default disabled
Having this enabled caused a significant heap-usage increase even if
there were no performance logging plugins installed.
Bug:https://crbug.com/gerrit/15531
Release-Notes: tracing.performanceLogging is default disabled
Change-Id: I4d2674eeeff64fe1ea1d79ef1f3472944936e054
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/Documentation/config-gerrit.txt
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/javatests/com/google/gerrit/server/logging/LoggingContextAwareExecutorServiceTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/javatests/com/google/gerrit/acceptance/ssh/SshTraceIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/java/com/google/gerrit/server/logging/PerformanceLogContext.java
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/javatests/com/google/gerrit/server/logging/PerformanceLogContextTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/c5fcca0dfafe309099ffb8f0adabbed094ed4337/javatests/com/google/gerrit/acceptance/rest/TraceIT.java
commit c5fcca0dfafe309099ffb8f0adabbed094ed4337
Author: Sven Selberg <svense@axis.com>
Date: Fri Apr 22 11:37:53 2022
Make tracing.performanceLogging default disabled
Having this enabled caused a significant heap-usage increase even if
there were no performance logging plugins installed.
Bug:
Release-Notes: tracing.performanceLogging is default disabled
Change-Id: I4d2674eeeff64fe1ea1d79ef1f3472944936e054
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. Install Gerrit v3.4
2. List the number of metrics exported
3. Upgrade to Gerrit v3.5
4. List the number of metrics exported
What is the expected output?
The two numbers *may not match* but should have the same order of magnitude
What do you see instead?
Gerrit v3.4 has hundreds of metrics
Gerrit v3.5 has thousands of metrics
Please provide any additional information below.https://gerrit-review.googlesource.com/c/gerrit/+/318346
It looks like the difference is mainly due to the new performance metrics introduced in