Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Pending code changes (auto-populated)
The version field defines the version of the software the bug was found in. [ID: 1154637]
View issue level access limits(Press Alt + Right arrow for more information)
Unintended behavior
View staffing
Description
#1Gerrit has quite a lot of usages of JGit's PersonIdent class. PersonIdent currently doesn't support Instant, but requires a java.util.Date as input to the constructors and only has getter for the timestamp that returns java.util.Date. Due to this ErrorProne flags a lot of JdkObsolete violations in Gerrit (also seehttps://crbug.com/gerrit/15070 ).
To fix this we should:
1. Update PersonIdent in JGit to support Instants (offer constructors
that accept Instant + add a getter that returns Instant)
2. Upgrade JGit in Gerrit
3. Fix Gerrit's usages of PersonIdent to use the new constructors + getter
David O. has already started with 1. and uploaded this as a change to JGit [1] (still in review).
[1]https://git.eclipse.org/r/c/jgit/jgit/+/189192