Verified
Status Update
Comments
da...@gmail.com <da...@gmail.com> #2
[Empty comment from Monorail migration]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538
commit cf682faa8e349d13e2467ad8fe41bec2aabea538
Author: Edwin Kempin <ekempin@google.com>
Date: Tue Jan 04 10:50:52 2022
Ignore JdkObsolete warnings for using Date with PersonIdent
PersonIdent of JGit doesn't support Instant yet. Until this is fixed in
JGit we ignore the corresponding warnings so that this doesn't prevent
us from enabling the JdkObsolete error level.
To be able to find the corresponding places in the code easily, we added
'TODO(issue-15517)' comments, so that these places can get fixed when
https://crbug.com/gerrit/15517 is tackled.
Bug:https://crbug.com/gerrit/15070
Bug:https://crbug.com/gerrit/15517
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I4c2c1718ad10ae128ebfc7545af4657c50c4705e
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/account/Emails.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/restapi/change/Revisions.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/account/AccountConfig.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/notedb/ChangeNoteUtil.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/IdentifiedUser.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/restapi/change/CreateChange.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/pgm/init/AccountsOnInit.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/restapi/project/ListTags.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/extensions/common/GitPerson.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/notedb/CommitRewriter.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/account/AccountsUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/group/db/AuditLogReader.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/restapi/project/GetReflog.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/notedb/ChangeNotesParser.java
[modify]https://gerrit.googlesource.com/gerrit/+/cf682faa8e349d13e2467ad8fe41bec2aabea538/java/com/google/gerrit/server/CommonConverters.java
commit cf682faa8e349d13e2467ad8fe41bec2aabea538
Author: Edwin Kempin <ekempin@google.com>
Date: Tue Jan 04 10:50:52 2022
Ignore JdkObsolete warnings for using Date with PersonIdent
PersonIdent of JGit doesn't support Instant yet. Until this is fixed in
JGit we ignore the corresponding warnings so that this doesn't prevent
us from enabling the JdkObsolete error level.
To be able to find the corresponding places in the code easily, we added
'TODO(issue-15517)' comments, so that these places can get fixed when
Bug:
Bug:
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I4c2c1718ad10ae128ebfc7545af4657c50c4705e
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf
commit 3bc970bb3e689d1d340382c3f5e5285d44f91dbf
Author: Edwin Kempin <ekempin@google.com>
Date: Fri May 20 11:47:59 2022
Fix JdkObsolete: Use new methods from PersonIdent to avoid Date/TimeZone
The Date and TimeZone classes are deprecated and should no longer be
used. PersonIdent from JGit has now been updated so that it supports
Instant/ZoneId in addition to Date/TimeZone. Make use of the new
PersonIdent methods so that we do not need to suppress warnings when
dealing with PersonIdent.
Bug:https://crbug.com/gerrit/15517
Release-Notes: skip
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib64437a115d40eb2e455c32918a1d363a028126c
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/account/Emails.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/extensions/common/testing/GitPersonSubject.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/git/BanCommit.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/change/PutMessage.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/account/AccountsUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/group/db/GroupConfig.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/group/db/GroupConfigTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/group/CreateGroup.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/project/GetReflog.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/ProjectResetterTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/update/Context.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/account/AccountConfig.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/project/CreateTag.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/api/group/GroupsIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/group/db/AbstractGroupTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/group/db/AuditLogReader.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/notedb/CommitRewriterTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/group/db/GroupNameNotesTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/patch/MagicFileTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/git/CommitUtil.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/server/change/ConsistencyCheckerIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/IdentifiedUser.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/pgm/init/AccountsOnInit.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/project/ListTags.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/notedb/CommitMessageOutputTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/patch/DiffOperationsTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/notedb/CommitRewriter.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/pgm/init/GroupsOnInit.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/notedb/ChangeNotesParser.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/testing/TestChanges.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/git/meta/VersionedMetaDataTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/change/Revisions.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/acceptance/testsuite/change/ChangeOperationsImpl.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/notedb/ChangeNoteUtil.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/edit/ChangeEditModifier.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/change/CreateChange.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/update/BatchUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/restapi/change/CherryPickChange.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/server/git/DeleteZombieCommentsRefsTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/3bc970bb3e689d1d340382c3f5e5285d44f91dbf/java/com/google/gerrit/server/CommonConverters.java
commit 3bc970bb3e689d1d340382c3f5e5285d44f91dbf
Author: Edwin Kempin <ekempin@google.com>
Date: Fri May 20 11:47:59 2022
Fix JdkObsolete: Use new methods from PersonIdent to avoid Date/TimeZone
The Date and TimeZone classes are deprecated and should no longer be
used. PersonIdent from JGit has now been updated so that it supports
Instant/ZoneId in addition to Date/TimeZone. Make use of the new
PersonIdent methods so that we do not need to suppress warnings when
dealing with PersonIdent.
Bug:
Release-Notes: skip
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib64437a115d40eb2e455c32918a1d363a028126c
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
ek...@google.com <ek...@google.com> #7
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #8
[Monorail components: Backend]
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4
commit 25c60c77c6fc07cce374934e6051df37fcb50dc4
Author: Edwin Kempin <ekempin@google.com>
Date: Fri May 20 11:47:59 2022
Fix JdkObsolete: Use new methods from PersonIdent to avoid Date/TimeZone
The Date and TimeZone classes are deprecated and should no longer be
used. PersonIdent from JGit has now been updated so that it supports
Instant/ZoneId in addition to Date/TimeZone. Make use of the new
PersonIdent methods so that we do not need to suppress warnings when
dealing with PersonIdent.
Bug:https://crbug.com/gerrit/15517
Release-Notes: skip
Forward-Compatible: checked
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib64437a115d40eb2e455c32918a1d363a028126c
(cherry picked from commit 3bc970bb3e689d1d340382c3f5e5285d44f91dbf)
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/account/Emails.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/change/CreateMergePatchSet.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/extensions/common/testing/GitPersonSubject.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/git/BanCommit.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/change/PutMessage.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/account/AccountsUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/group/db/GroupConfig.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/api/revision/RevisionDiffIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/group/db/GroupConfigTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/group/CreateGroup.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/project/GetReflog.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/ProjectResetterTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/update/Context.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/api/accounts/AccountIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/account/AccountConfig.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/project/CreateTag.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/api/group/GroupsIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/group/db/AbstractGroupTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/group/db/AuditLogReader.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/notedb/CommitRewriterTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/group/db/GroupNameNotesTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/patch/MagicFileTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/git/CommitUtil.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/server/change/ConsistencyCheckerIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/IdentifiedUser.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/pgm/init/AccountsOnInit.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/project/ListTags.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/notedb/CommitMessageOutputTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/patch/DiffOperationsTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/notedb/CommitRewriter.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/pgm/init/GroupsOnInit.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/notedb/ChangeNotesParser.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/testing/TestChanges.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/git/meta/VersionedMetaDataTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/change/Revisions.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/acceptance/testsuite/change/ChangeOperationsImpl.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/notedb/ChangeNoteUtil.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/edit/ChangeEditModifier.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/change/CreateChange.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/update/BatchUpdate.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/restapi/change/CherryPickChange.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/api/revision/RevisionIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/server/git/DeleteZombieCommentsRefsTest.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java
[modify]https://gerrit.googlesource.com/gerrit/+/25c60c77c6fc07cce374934e6051df37fcb50dc4/java/com/google/gerrit/server/CommonConverters.java
commit 25c60c77c6fc07cce374934e6051df37fcb50dc4
Author: Edwin Kempin <ekempin@google.com>
Date: Fri May 20 11:47:59 2022
Fix JdkObsolete: Use new methods from PersonIdent to avoid Date/TimeZone
The Date and TimeZone classes are deprecated and should no longer be
used. PersonIdent from JGit has now been updated so that it supports
Instant/ZoneId in addition to Date/TimeZone. Make use of the new
PersonIdent methods so that we do not need to suppress warnings when
dealing with PersonIdent.
Bug:
Release-Notes: skip
Forward-Compatible: checked
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ib64437a115d40eb2e455c32918a1d363a028126c
(cherry picked from commit 3bc970bb3e689d1d340382c3f5e5285d44f91dbf)
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
Description
Gerrit has quite a lot of usages of JGit's PersonIdent class. PersonIdent currently doesn't support Instant, but requires a java.util.Date as input to the constructors and only has getter for the timestamp that returns java.util.Date. Due to this ErrorProne flags a lot of JdkObsolete violations in Gerrit (also seehttps://crbug.com/gerrit/15070 ).
To fix this we should:
1. Update PersonIdent in JGit to support Instants (offer constructors
that accept Instant + add a getter that returns Instant)
2. Upgrade JGit in Gerrit
3. Fix Gerrit's usages of PersonIdent to use the new constructors + getter
David O. has already started with 1. and uploaded this as a change to JGit [1] (still in review).
[1]https://git.eclipse.org/r/c/jgit/jgit/+/189192