Status Update
Comments
br...@google.com <br...@google.com> #2
[Empty comment from Monorail migration]
ja...@gmail.com <ja...@gmail.com> #3
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #4
Gerrit was using following regexp in gerrit.config:
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =https://bugs.chromium.org/p/gerrit/issues/detail?id=$2
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
jo...@gmail.com <jo...@gmail.com> #5
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #6
[Empty comment from Monorail migration]
is...@google.com <is...@google.com> #7
Edits were made to reflect the following in Monorail: auto-CCs.
br...@google.com <br...@google.com>
pi...@gmail.com <pi...@gmail.com> #8
I have a scenario where this feature is very important. We have a CI machinery that posts +/-1 score but also posts details on what test suites were run, outcome for each of them as well as links to the logs.
If new patch fixes all test issues and you get "+1 Verify" then browsing old logs/comments is not that critical. But we live in the real world...
When a new PS is uplifted it's extremely helpful to be able to expand the message from CI on a previous patch in order to see and compare if it was same test(s) that failed or not and if my patch helped to resolve the problem or introduce new issue(s). With the new Gerrit3 feature of "log hiding" I have to press "Show all entries" every time I open a commit just in case it filters away some important information. That's why I think it would be good if you could make it something that could be configured in settings and I could choose to see ALL the comments all the time.
In general, in our organization change log is already beyond saving with all the automation from adding reviewers, CI info, verdicts, comments etc. So saving couple of lines won't make changelog more compact/readable. In this case it's better to see everything all the time than missing something important.
Our CI will also post comments stating what tests were started and links pointing to separate Jenkins runs. By being able to see and compare new vs old patch comments I can also see if the scope of the testing was changed due to my changes. This also required me to be able to see all the logs all the time.
If new patch fixes all test issues and you get "+1 Verify" then browsing old logs/comments is not that critical. But we live in the real world...
When a new PS is uplifted it's extremely helpful to be able to expand the message from CI on a previous patch in order to see and compare if it was same test(s) that failed or not and if my patch helped to resolve the problem or introduce new issue(s). With the new Gerrit3 feature of "log hiding" I have to press "Show all entries" every time I open a commit just in case it filters away some important information. That's why I think it would be good if you could make it something that could be configured in settings and I could choose to see ALL the comments all the time.
In general, in our organization change log is already beyond saving with all the automation from adding reviewers, CI info, verdicts, comments etc. So saving couple of lines won't make changelog more compact/readable. In this case it's better to see everything all the time than missing something important.
Our CI will also post comments stating what tests were started and links pointing to separate Jenkins runs. By being able to see and compare new vs old patch comments I can also see if the scope of the testing was changed due to my changes. This also required me to be able to see all the logs all the time.
ek...@google.com <ek...@google.com> #9
Thanks for providing context. For us at Google filtering entries in the change log is intended and working well, hence working on this is not a priority for us.
Description
# Template for reporting issues about the Cleaner Change Log experimenthttps://www.gerritcodereview.com/2020-05-06-change-log-
# see
experiment.html
#
# Please provide change page links and screenshots!
How can I set "Show all entries" to be on by default? It is hiding important log entries, and just confuses it all.