Gerrit

I think it makes sense to highlight entries from service users in the change log in general. Maybe then we don't need a css var to customize it?

@Delphine: WDYT? Do you have an idea for how to highlight rows from service users? Background color as suggested? Icon?

[Monorail components: PolyGerrit>UX]

I think adding a colored background to the service users would draw a lot of the attention, especially because the background is quite wide.  See an attached screenshot for reference.

Instead, we could deemphasize the service users usernames so that the other users are more prominent in the change log.

Service usernames would use use --deemphasized-text-color: var(--gray-700); and --font-weight-normal: 400;

See the attached screenshot Proposal_deemphasize_service_usernames.png

Would this work for you?

> Instead, we could deemphasize the service users usernames so that the other users are more prominent in the change log.

What if we expose some CSS variables instead? So that people can define the style they would like to have?

> What if we expose some CSS variables instead? So that people can define the style they would like to have?

+1

We discussed it in the team, we can add a css variable to service users in the change log. This css variable will affect the background color of the row of a service user in the change log.
 

We also thought about adding a default avatar for service users. Having a similar avatar will help set service users apart from other users. We propose to use a robot icon (see attached screenshot).

If an avatar is set for the service user, then it will show the set avatar (like the avatar for GerritCI).

>We discussed it in the team, we can add a css variable to service users in the change log. This css variable will affect the background color of the row of a service user in the change log.
 
>We also thought about adding a default avatar for service users. Having a similar avatar will help set service users apart from other users. We propose to use a robot icon (see attached screenshot).

Nice one, this would perfectly address my use case.

Thanks

@Fabio: Does "this would perfectly address my use case" refer to the background color variable or the avatar?

@Delphine: The background color variable is simple enough to add. The avatar is a bit trickier, at least if we want service users to still be able to set an avatar. Because even if no avatar is set, then Google still sends us an avatar, and we can't really know that it is the default one.

Sorry, I was referring to the background color. The avatar is a nice to have.

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit/+/24c47ed82a1043f678601b1db8ef18977c856829

commit 24c47ed82a1043f678601b1db8ef18977c856829
Author: Ben Rohlfs <brohlfs@google.com>
Date: Wed Feb 10 21:13:53 2021

Add a css var for coloring change log entries by service users

Bug: https://crbug.com/gerrit/13836
Change-Id: Ib5564ff213d4f6fbbf0f4222c93e7c5305c0ecd3

[modify] https://gerrit.googlesource.com/gerrit/+/24c47ed82a1043f678601b1db8ef18977c856829/polygerrit-ui/app/elements/change/gr-message/gr-message_html.ts
[modify] https://gerrit.googlesource.com/gerrit/+/24c47ed82a1043f678601b1db8ef18977c856829/polygerrit-ui/app/elements/change/gr-message/gr-message.ts
[modify] https://gerrit.googlesource.com/gerrit/+/24c47ed82a1043f678601b1db8ef18977c856829/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list_html.ts

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Monorail components: -PolyGerrit>UX]

Edits were made to reflect the following in Monorail: auto-CCs.