Obsolete
Status Update
Comments
mr...@gmail.com <mr...@gmail.com> #2
[Empty comment from Monorail migration]
sn...@gmail.com <sn...@gmail.com> #3
[Empty comment from Monorail migration]
is...@google.com <is...@google.com> #4
Gerrit was using following regexp in gerrit.config:
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =https://bugs.chromium.org/p/gerrit/issues/detail?id=$2
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
Description
# Template for reporting issues about the Cleaner Change Log experimenthttps://www.gerritcodereview.com/2020-05-06-change-log-
# see
experiment.html
#
# Please provide change page links and screenshots!
"Users likely prefer a bit more scrolling than having to expand some hidden messages."
If that is known, what motivated this change? It is quite incovenient to have to constantly click to show previous mails in a review. If this change goes through, I'd suggest adding an option to change the default value (on vs off).
This change assumes that old reviews have been solved, and thus are less important, but I'd say that is an incorrect assumption. Since patches can stay in review for a *very* long time, rebases end up hiding older messages (mainly in open source projects). Also, not all comments may have been solved, so hiding older messages only makes it easier to forget them (unresolved comments are only displayed when comparing patch versions on which the comment was created).