Fixed
Status Update
Comments
ca...@chromium.org <ca...@chromium.org> #2
[Empty comment from Monorail migration]
mi...@google.com <mi...@google.com> #3
[Empty comment from Monorail migration]
mi...@google.com <mi...@google.com> #4
Gerrit was using following regexp in gerrit.config:
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =https://bugs.chromium.org/p/gerrit/issues/detail?id=$2
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
br...@google.com <br...@google.com> #5
[Empty comment from Monorail migration]
is...@google.com <is...@google.com> #6
[Empty comment from Monorail migration]
Description
Screenshot attached.
I generally like the new Changelog experiment (
There are a few entries that don't provide much signal that I'd remove in the default (not show-all) view. I've highlighted these in red boxes in the attached screenshot.
I'll also list these textually in the bug. For this set of messages:
Commit Bot
Added to cc: Commit Bot
1 May 21 7:14 PM
Alex Turner
Set Ready For Review
1 May 21 7:15 PM
Alex Turner
Added to reviewer: Caleb Raitto
1 May 21 7:16 PM
Alex Turner
Hey Caleb, could you PTAL? Based on Asanka's cl, it seems that we probably don't want additional overloads going forward
1 May 21 7:17 PM
Caleb Raitto
2 comments
If it's OK, I'd like to hold off on this approach until we come to a consensus on what we're doing with the existing helper functions in
1 May 21 7:55 PM
Alex Turner
2 comments
Yep, that sounds good! Mainly just wanted to unblock the other cl, but there's no hurry. Maybe let's wait on this until the other is a bit more solid
1 May 21 9:01 PM
Alex Turner
Caleb, I had a go moving the helper to blink/platform now that the approach seems more solidified. Could you PTAL? Thanks!
4 Jun 05 1:52 PM
Alex Turner
Uploaded patch set 5: Commit-Queue+1. minor
5 2:13 PM
Commit Bot
Dry run: CQ is trying the patch. Follow status at:
5 2:14 PM
Commit Bot on behalf of Alex Turner Commit-Queue removed
5 2:27 PM
Commit Bot
Dry run: Failed builds: luci.chromium.try/mac_chromium_compile_dbg_ng JOB_FAILED
5 2:27 PM
Caleb Raitto
1 comment
Will review more soon, build suggestion for now.
I'd remove these 3 low-signal messages:
Commit Bot
Added to cc: Commit Bot
5 2:13 PM
Commit Bot
Dry run: CQ is trying the patch. Follow status at:
5 2:14 PM
Commit Bot on behalf of Alex Turner Commit-Queue removed