Fixed
Status Update
Comments
da...@gmail.com <da...@gmail.com> #2
[Empty comment from Monorail migration]
ta...@google.com <ta...@google.com> #3
The main features are shown on the main index of the home page. Should the about page include the same information that is there, or be more detailed?
ta...@google.com <ta...@google.com> #4
I would say more details. Alternatively we could just rename it to "Project History" and move it to a less prominent place.
ta...@google.com <ta...@google.com> #5
[Monorail components: Homepage]
lu...@gmail.com <lu...@gmail.com> #6
[Monorail components: Documentation]
ta...@google.com <ta...@google.com> #7
[Monorail components: -docs]
lu...@gmail.com <lu...@gmail.com> #8
[Empty comment from Monorail migration]
lu...@gmail.com <lu...@gmail.com> #9
[Description Changed]
lu...@gmail.com <lu...@gmail.com> #10
It looks like the sinonjs's guy decided to remove its repository exactly this morning, and the stable-2.16 build was run last night.
So, now, we have also v2.16 impacted.
This is *very* worrying for me, that means that we are unable to guarantee that a successful build can be re-run :-(
How can we avoid pulling 'flaky' dependencies into our build?
So, now, we have also v2.16 impacted.
This is *very* worrying for me, that means that we are unable to guarantee that a successful build can be re-run :-(
How can we avoid pulling 'flaky' dependencies into our build?
ta...@google.com <ta...@google.com> #11
so https://github.com/sinonjs/sinon/tree/d5512942fa64d3775760af3cfb22cdd297fca38c (v1.17.1) seems not support bower :( I guess that why we use the first sinon.js before...
alternatives are:
1. we fork the v.17.1 and build it and publish package tobower.io
2. or we import the sinon.js into the code base `lib/` as a standalone file
or ?
alternatives are:
1. we fork the v.17.1 and build it and publish package to
2. or we import the sinon.js into the code base `lib/` as a standalone file
or ?
lu...@gmail.com <lu...@gmail.com> #12
I would opt for the 2. if possible: do we need the permission of the code owner and the signing of a CLA?
ta...@google.com <ta...@google.com> #13
i think we can just use the build one from polymer: https://github.com/Polymer/sinon.js (under BSD license)
ta...@google.com <ta...@google.com> #14
since it broke the polymer, i think it will get fixed soon, maybe we should just wait for it
br...@google.com <br...@google.com> #15
Yeah, this is basically a Polymer breakage, not our fault. Can we wait 24 hours or do we have to fix this ASAP?
lu...@gmail.com <lu...@gmail.com> #16
The problem is that all the validations would return Verified -1 :-( Can we at least disable the tests in the meantime?
ta...@google.com <ta...@google.com> #17
that will block development of FE, we can not submit changes without any UI tests :(
br...@google.com <br...@google.com> #18
I think we should submit Tao's fix on master, but I am not sure about 3.0 and 3.1. Options:
1) Pick Tao's fix
2) Let 3.0 and 3.1 be broken for 24h
3) Disable UI tests on 3.0 and 3.1 for 24h
What do you all prefer?
1) Pick Tao's fix
2) Let 3.0 and 3.1 be broken for 24h
3) Disable UI tests on 3.0 and 3.1 for 24h
What do you all prefer?
ta...@google.com <ta...@google.com> #19
as they mentioned, they are working on either bringing back that repo or re-registering the name to Polymer/sinonjs. any of these two should fix the issue and we may just need to update the sha1 of sinonjs package to adapt the change. if we submit the fix, we can revert it later easily and apply same sha change once fixed.
br...@google.com <br...@google.com> #20
> they are working
None of these folks are Polymer maintainers AFAIK. I think we need California to wake up. Otherwise that issue won't see any real progress.
None of these folks are Polymer maintainers AFAIK. I think we need California to wake up. Otherwise that issue won't see any real progress.
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #21
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6
commit 48026defc8ae48e76f29a583544779f7295446a6
Author: Tao Zhou <taoalpha@google.com>
Date: Mon Feb 10 13:24:06 2020
Fix missing sinon lib
As original sinon.js from bower (https://github.com/blittle/sinon.js/ )
is not availble any more,
and official release of sinonjs/sinon doesn't support bower for v1.17.1,
we decided to import standalone js file from:
https://github.com/Polymer/sinon.js
Keep the name as `sinonjs` as thats required by wct:
https://github.com/Polymer/web-component-tester/blob/master/browser.js#L223
Bug:https://crbug.com/gerrit/12304
Change-Id: Idc97ef4808be6ed30c7ed2e9c580d09b1338d4de
[add]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/LICENSE-sinon
[modify]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/js/BUILD
[modify]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/js/bower_archives.bzl
[modify]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/js/bower_components.bzl
[add]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/sinon/BUILD
[add]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/lib/sinon/sinon.js
[modify]https://gerrit.googlesource.com/gerrit.git/+/48026defc8ae48e76f29a583544779f7295446a6/polygerrit-ui/app/BUILD
commit 48026defc8ae48e76f29a583544779f7295446a6
Author: Tao Zhou <taoalpha@google.com>
Date: Mon Feb 10 13:24:06 2020
Fix missing sinon lib
As original sinon.js from bower (
is not availble any more,
and official release of sinonjs/sinon doesn't support bower for v1.17.1,
we decided to import standalone js file from:
Keep the name as `sinonjs` as thats required by wct:
Bug:
Change-Id: Idc97ef4808be6ed30c7ed2e9c580d09b1338d4de
[add]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
ta...@google.com <ta...@google.com> #24
[Empty comment from Monorail migration]
is...@google.com <is...@google.com> #25
Edits were made to reflect the following in Monorail: auto-CCs.
Description
*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
Affected Version: Gerrit 2.16/3.0/3.1
What steps will reproduce the problem?
1. Run Gerrit PolyGerrit build
What is the expected output?
The build succeed
What do you see instead?bower@1.8.8.npm_binary.tgz ", "-n", "sinonjs", "-p", "sinonjs", "-v", "1.17.1", "-s", "a26a6aab7358807de52ba738770f6ac709afd240", "-o", "sinonjs__download_bower.zip"]: [{
The build fails with:
07:16:54 INFO: Call stack for the definition of repository 'sinonjs' which is a bower_archive (rule definition at /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/tools/bzl/js.bzl:122:17):
07:16:54 - /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/lib/js/bower_archives.bzl:150:5
07:16:54 - /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/lib/js/bower_archives.bzl:150:5
07:16:54 - /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/WORKSPACE:1162:1
07:16:54 Analyzing: 2 targets (3 packages loaded, 3242 targets configured)
07:16:54 ERROR: An error occurred during the fetch of repository 'sinonjs':
07:16:54 failed [/usr/bin/python, /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/tools/js/download_bower.py, "-b", "/usr/bin/python /home/jenkins/workspace/Gerrit-bazel-stable-3.0/gerrit/tools/js/run_npm_binary.py /home/jenkins/.cache/bazel/_bazel_jenkins/0b2e4e9b81dd3357bafca25fb4e1d497/external/bower/
07:16:54 "code": "ECMDERR",
07:16:54 "details": "remote: Invalid username or password.\nfatal: Authentication failed for 'https://github.com/blittle/sinon.js.git/'\n",
07:16:54 "exitCode": 128,
07:16:54 "data": {
07:16:54 "endpoint": {
07:16:54 "name": "",
07:16:54 "source": "sinonjs",
07:16:54 "target": "1.17.1"
07:16:54 },
07:16:54 "resolver": {
07:16:54 "name": "sinonjs",
07:16:54 "source": "https://github.com/blittle/sinon.js.git",
07:16:54 "target": "1.17.1"
07:16:54 }
07:16:54 },
07:16:54 "id": "ECMDERR",
07:16:54 "level": "error",
07:16:54 "message": "Failed to execute "git ls-remote --tags --heads https://github.com/blittle/sinon.js.git", exit code of #128\nremote: Invalid username or password.\nfatal: Authentication failed for 'https://github.com/blittle/sinon.js.git/'\n",
07:16:54 "stacktrace": "Error: Failed to execute "git ls-remote --tags --heads https://github.com/blittle/sinon.js.git", exit code of #128\nremote: Invalid username or password.\nfatal: Authentication failed for 'https://github.com/blittle/sinon.js.git/'\n\n at createError (/home/jenkins/.cache/bazel/_bazel_jenkins/0b2e4e9b81dd3357bafca25fb4e1d497/external/bower/bower@1.8.8-82544be34a33aeae7efb8bdf9905247b2cffa985/package/lib/util/createError.js:4:15)\n at ChildProcess.<anonymous> (/home/jenkins/.cache/bazel/_bazel_jenkins/0b2e4e9b81dd3357bafca25fb4e1d497/external/bower/bower@1.8.8-82544be34a33aeae7efb8bdf9905247b2cffa985/package/lib/util/cmd.js:102:21)\n at ChildProcess.emit (events.js:198:13)\n at maybeClose (internal/child_process.js:982:16)\n at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)"
07:16:54 }]
Please provide any additional information below.
https://github.com/blittle/sinon.js.git
It looks like the build tries to download a private (or non-existent?) JS component from GitHub:
Setting this as P0 because the build is currently broken on v3.0 and v3.1