Bazel: Current build tool chain is incompatible with --incompatible_disallow_empty_glob flag [40011754]

Fixed

Bug

merge-merged-stable-2.16

merge-merged-stable-3.0

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Dec 24, 2019 04:19PM

See: [1] for more details.

[1]

https://github.com/bazelbuild/bazel/issues/8195

Comments

da...@gmail.com <da...@gmail.com> #2Dec 24, 2019 08:10PM

https://gerrit-review.googlesource.com/c/gerrit/+/249292

https://gerrit-review.googlesource.com/c/plugins/webhooks/+/249276

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #3Dec 26, 2019 09:57AM

The following revision refers to this bug:

https://gerrit.googlesource.com/gerrit.git/+/235eccffe0e062e6c1e018da390dbfffa1a63a2b

commit 235eccffe0e062e6c1e018da390dbfffa1a63a2b
Author: David Ostrovsky <david@ostrovsky.org>
Date: Tue Dec 24 20:04:09 2019

Bazel: Remove unused polygerrit-ui/app:bower_components rule

The last usage was removed in I21f3ed67ade1, but the rule itself was
missed to be removed.

Bug:

https://crbug.com/gerrit/12110
Change-Id: Ib595e8ab2d3dd0e8ecd8635ad48670d9610062ed

[modify]

https://gerrit.googlesource.com/gerrit.git/+/235eccffe0e062e6c1e018da390dbfffa1a63a2b/polygerrit-ui/app/BUILD

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #4Dec 26, 2019 09:57AM

The following revision refers to this bug:

https://crbug.com/gerrit/12110
Change-Id: Ib595e8ab2d3dd0e8ecd8635ad48670d9610062ed

[modify]

https://gerrit.googlesource.com/gerrit.git/+/235eccffe0e062e6c1e018da390dbfffa1a63a2b/polygerrit-ui/app/BUILD

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #5Dec 26, 2019 09:58AM

The following revision refers to this bug:

https://crbug.com/gerrit/12110
Change-Id: Ib595e8ab2d3dd0e8ecd8635ad48670d9610062ed

[modify]

https://gerrit.googlesource.com/gerrit.git/+/235eccffe0e062e6c1e018da390dbfffa1a63a2b/polygerrit-ui/app/BUILD

da...@gmail.com <da...@gmail.com> #6Dec 26, 2019 11:49AM

Marked as fixed, reassigned to gg...@google.com.

[Empty comment from Monorail migration]

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #7Dec 28, 2019 10:00PM

The following revision refers to this bug:

https://gerrit.googlesource.com/gerrit.git/+/ce751c1d8bd2411dd98b82544b3464504278660d

commit ce751c1d8bd2411dd98b82544b3464504278660d
Author: Marco Miller <marco.miller@ericsson.com>
Date: Sat Dec 28 21:58:55 2019

Update git submodules

* Update plugins/webhooks from branch 'stable-3.0'
to 0b787b1abc35ac12cd0ea2a9242bafb15c93bd5b
- Merge branch 'stable-2.16' into stable-3.0

* stable-2.16:
Bump Bazel version to 2.0.0
Bazel: Remove empty glob
Upgrade bazlets to latest stable-2.16 to build with 2.16.15 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.14 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
Remove bazel-genfiles from .gitignore
Replace bazel-genfiles with bazel-bin in documentation

Change-Id: I83a8f4400e5f49b1453bbeac3cd93733a26be3fb

- Bump Bazel version to 2.0.0

Change-Id: I0a836dc57d4749ec5874afa5d1388e4e737cc618

- Bazel: Remove empty glob

Bug:

https://crbug.com/gerrit/12110
Change-Id: If9bf21aeab2428c45748870a7eaa0cc6baad6058

- Upgrade bazlets to latest stable-2.16 to build with 2.16.15 API

Change-Id: I8d8aa4924e85437283a66bf256fcce351a425af8

- Upgrade bazlets to latest stable-2.16 to build with 2.16.14 API

Change-Id: I1622a992c2a24deba350af915866775c299a4a50

- Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API

Change-Id: I53ea39b9eb2da2198b9175642cd62f6aed5fa2ec

- Upgrade bazlets to latest stable-2.16

download_file.py: Fix root workspace directory detection

Change-Id: I26017fc180b761feba2b5f01d4eb7a0e7c7b690c

- Merge branch 'stable-2.15' into stable-2.16

* stable-2.15:
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14

Change-Id: I3fd7407a08292ae56e93bea820a781c6e71c397f

- Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API

Change-Id: I5b0cfcdf3c988793ef0d8b1e56d012b26dff2614

- Merge branch 'stable-2.14' into stable-2.15

* stable-2.14:
Bazel: Migrate workspace status script to python

Change-Id: I141919270fe4590f38fc794ff4b65c8c54d66193

- Bazel: Migrate workspace status script to python

Migrate tools/workspace-status.sh script to Python to ensure better
compatibility with other operating systems, as suggested in: [1].

[1]

https://github.com/bazelbuild/bazel/issues/5958

Change-Id: I20ec325d610353309a40fc85132382004bc61bd0

- Merge branch 'stable-2.14' into stable-2.15

* stable-2.14:
Upgrade bazlets to latest stable-2.14

Change-Id: Ica546d49b8e6c1ce41e08ad6e0ab1c1d0153bccb

- Upgrade bazlets to latest stable-2.15

download_file.py: Fix root workspace directory detection

Change-Id: I1c5eb23dfe5978270c10ef6d2baaed7ecd0a04fc

- Upgrade bazlets to latest stable-2.14

download_file.py: Fix root workspace directory detection

Change-Id: Id2da57a98ab0344dc9942d9ff0338309494b0f48

- Upgrade bazlets to latest stable-2.16

Fix genrule2 to clean up temporary folder content

Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2

- Merge branch 'stable-2.15' into stable-2.16

* stable-2.15:
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0

Change-Id: Iabfc1dd9e5144e1506601c1cf62fc94c8764b654

- Upgrade bazlets to latest stable-2.15

Fix genrule2 to clean up temporary folder content

Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2

- Merge branch 'stable-2.14' into stable-2.15

* stable-2.14:
Upgrade bazlets to latest stable-2.14

Change-Id: I8620ef4dfc850e234759da59253ea2939566e730

- Upgrade bazlets to latest stable-2.14

Fix genrule2 to clean up temporary folder content

Change-Id: I1d186a2082b364f7acc2d99c20ec0211efebbfd2

- Merge branch 'stable-2.14' into stable-2.15

* stable-2.14:
Bump Bazel version to 1.1.0

Change-Id: I0059aac96c20c4245edf565198d693c6bd5da133

- Bump Bazel version to 1.1.0

Change-Id: I324d090b867d43741cd8d3eedcc12db054a60762

- Merge branch 'stable-2.15' into stable-2.16

* stable-2.15:
Remove bazel-genfiles from .gitignore
Replace bazel-genfiles with bazel-bin in documentation

Change-Id: I263039fc29ba0e5822ca63d93728d340bcb5d06f

- Merge branch 'stable-2.14' into stable-2.15

* stable-2.14:
Remove bazel-genfiles from .gitignore
Replace bazel-genfiles with bazel-bin in documentation

Change-Id: I6ff50d492444ea044f9814ea5d30e585bbd8e415

- Remove bazel-genfiles from .gitignore

Change-Id: I1af194ce981f0de2fdd5e52d1ff57b80300e1950

- Replace bazel-genfiles with bazel-bin in documentation

Bug:

https://crbug.com/gerrit/11757
Change-Id: Idd8a9b212db874f55902844f4522e8a25e3d6657

[modify]

https://gerrit.googlesource.com/gerrit.git/+/ce751c1d8bd2411dd98b82544b3464504278660d/plugins/webhooks

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #8Jan 9, 2020 05:22AM

The following revision refers to this bug:

https://crbug.com/gerrit/11757
Change-Id: Idd8a9b212db874f55902844f4522e8a25e3d6657

[modify]

https://gerrit.googlesource.com/gerrit.git/+/ce751c1d8bd2411dd98b82544b3464504278660d/plugins/webhooks

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #9Jan 9, 2020 06:38AM

The following revision refers to this bug:

https://gerrit.googlesource.com/gerrit.git/+/b426ce5610bfe2df810968190ce80e1e0ccde7bd

commit b426ce5610bfe2df810968190ce80e1e0ccde7bd
Author: David Pursehouse <dpursehouse@collab.net>
Date: Thu Jan 09 06:34:16 2020

Update git submodules

* Update plugins/webhooks from branch 'master'
to 377fec17d2c0fc71cdfb1d12f502cfa1eba1fbd7
- Merge branch 'stable-3.0'

* stable-3.0:
Remove .gitignore file
Bump Bazel version to 2.0.0
Bazel: Remove empty glob
Upgrade bazlets to latest stable-2.16 to build with 2.16.15 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.14 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
Remove bazel-genfiles from .gitignore
Replace bazel-genfiles with bazel-bin in documentation

Change-Id: I4dc59310b6734cc16ae0ea522d8376880901e274

- Remove .gitignore file

Webhooks plugin is promoted to core gerrit plugins and the standalone
build mode was removed, but the .gitignore file was missed to be
removed.

Change-Id: Id973535668c628a937d3d39888443dc15e39affa

- Merge branch 'stable-2.16' into stable-3.0

* stable-2.16:
Bump Bazel version to 2.0.0
Bazel: Remove empty glob
Upgrade bazlets to latest stable-2.16 to build with 2.16.15 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.14 API
Upgrade bazlets to latest stable-2.16 to build with 2.16.13 API
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15 to build with 2.15.18 API
Bazel: Migrate workspace status script to python
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Upgrade bazlets to latest stable-2.16
Upgrade bazlets to latest stable-2.15
Upgrade bazlets to latest stable-2.14
Bump Bazel version to 1.1.0
Remove bazel-genfiles from .gitignore
Replace bazel-genfiles with bazel-bin in documentation

Change-Id: I83a8f4400e5f49b1453bbeac3cd93733a26be3fb

- Bump Bazel version to 2.0.0

Change-Id: I0a836dc57d4749ec5874afa5d1388e4e737cc618

- Bazel: Remove empty glob

Bug:

https://crbug.com/gerrit/11757
Change-Id: Idd8a9b212db874f55902844f4522e8a25e3d6657

[modify]

https://gerrit.googlesource.com/gerrit.git/+/b426ce5610bfe2df810968190ce80e1e0ccde7bd/plugins/webhooks

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #10Jan 22, 2020 05:40PM

The following revision refers to this bug:

https://crbug.com/gerrit/11757
Change-Id: Idd8a9b212db874f55902844f4522e8a25e3d6657

[modify]

https://gerrit.googlesource.com/gerrit.git/+/ce751c1d8bd2411dd98b82544b3464504278660d/plugins/webhooks

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #11Jan 22, 2020 05:40PM

The following revision refers to this bug:

https://crbug.com/gerrit/11757
Change-Id: Idd8a9b212db874f55902844f4522e8a25e3d6657

[modify]

https://gerrit.googlesource.com/gerrit.git/+/b426ce5610bfe2df810968190ce80e1e0ccde7bd/plugins/webhooks

is...@google.com <is...@google.com> #12Jan 22, 2020 05:40PM

Edits were made to reflect the following in Monorail: auto-CCs.

xa...@gmail.com <xa...@gmail.com> #13Jan 5, 2024 01:09PM

Please consider reopening this ticket, Gerrit is not building with incompatible_disallow_empty_glob

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1760#018cccd7-35a6-4c08-b8f1-096fb886341b

(01:27:50) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/builds/bk-docker-8s31/bazel-org-repo-root/gerrit/tools/js/eslint-rules/BUILD", line 10, column 16, in <toplevel>
		srcs = glob(["**/*.js"]),
Error in glob: glob pattern '**/*.js' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
(01:27:50) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/builds/bk-docker-8s31/bazel-org-repo-root/gerrit/Documentation/BUILD", line 34, column 16, in <toplevel>
		srcs = glob([
Error in glob: glob pattern 'images/*.jpg' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
(01:27:50) ERROR: package contains errors: Documentation
(01:27:50) ERROR: package contains errors: tools/js/eslint-rules
(01:27:56) ERROR: Traceback (most recent call last):
	File "/var/lib/buildkite-agent/builds/bk-docker-8s31/bazel-org-repo-root/gerrit/polygerrit-ui/app/BUILD", line 36, column 16, in <toplevel>
		srcs = glob(
Error in glob: glob pattern 'api/**/*.js' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
(01:27:56) ERROR: package contains errors: polygerrit-ui/app
(01:27:56) ERROR: Error evaluating '//...': error loading package 'Documentation': Package 'Documentation' contains errors

To prevent regressions in the future I would recommend to set the flag in the CI

Issue 40011754

Description

Issue summary

Comments

da...@gmail.com <da...@gmail.com> #2Dec 24, 2019 08:10PM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #3Dec 26, 2019 09:57AM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #4Dec 26, 2019 09:57AM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #5Dec 26, 2019 09:58AM

da...@gmail.com <da...@gmail.com> #6Dec 26, 2019 11:49AM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #7Dec 28, 2019 10:00PM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #8Jan 9, 2020 05:22AM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #9Jan 9, 2020 06:38AM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #10Jan 22, 2020 05:40PM

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #11Jan 22, 2020 05:40PM

is...@google.com <is...@google.com> #12Jan 22, 2020 05:40PM

xa...@gmail.com <xa...@gmail.com> #13Jan 5, 2024 01:09PM

Add comment

Issue metadata