Status Update
Comments
br...@google.com <br...@google.com> #2
I can reproduce on https://review.gerrithub.io/c/spdk/spdk/+/469228/13/include/spdk/bdev.h
"press c to comment" does not even show up. And if the "current line" is line 10, and if you select something in line 5, then pressing c would actually create a comment on line 10.
Tao or Paladox, can you have a look?
"press c to comment" does not even show up. And if the "current line" is line 10, and if you select something in line 5, then pressing c would actually create a comment on line 10.
Tao or Paladox, can you have a look?
is...@google.com <is...@google.com> #4
Edits were made to reflect the following in Monorail: auto-CCs.
Description
Affected Version: 3.1.0
What steps will reproduce the problem?
1. Select some text from a file you're reviewing
2. Press 'c' to add a comment
3. The selected text doesn't stay highlighted, the comment turns into a line comment.
What is the expected output?
The selected text should stay highlighted while the comment box is open, comment should be applied only to the selected text.
What do you see instead?
Comment turns into a line comment.
Please provide any additional information below.
This used to work in older versions (I believe at least in 3.0.3). I'm running macOS Safari version 13.0.3 (15608.3.10.1.4)).