Status Update
No update yet.
Comments
ek...@google.com
[Empty comment from Monorail migration]
ek...@google.com
hi...@google.com
We want to discuss this F2F at the next hackathon
br...@google.com
Patrick, did a F2F discussion happen at the hackathon?
hi...@google.com
Unfortunately not
os...@gmx.de
just a change-id is potentially ambiguous, so it seems unlikely that someone is using it, as they would have most probably run into trouble already. therefore, a removal without further deprecation would be likely acceptable.
as for the others, a timeline of the changing preference would be helpful. i thought that the numeric ids were supposed to go away completely, but now they are the preferred format, in conjunction with the project name (for sharding, but triplets would support that as well).
my personal view is that the triplets were a historical accident and can be safely deprecated, while the project name as a "decoration" to the numeric id should be a recommendation (as han-wen suggests).
as for the others, a timeline of the changing preference would be helpful. i thought that the numeric ids were supposed to go away completely, but now they are the preferred format, in conjunction with the project name (for sharding, but triplets would support that as well).
my personal view is that the triplets were a historical accident and can be safely deprecated, while the project name as a "decoration" to the numeric id should be a recommendation (as han-wen suggests).
da...@gmail.com
We discussed this in yesterday's ESC meeting. The decision is to remove the deprecation notice and continue supporting all the forms of change Id.
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:https://crbug.com/gerrit/11772
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/config-gerrit.txt
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/rest-api-changes.txt
[delete]https://gerrit.googlesource.com/gerrit.git/+/c9dc6e9a1177d2714a9b4850f1aef0d658f60230/java/com/google/gerrit/extensions/restapi/DeprecatedIdentifierException.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/change/ChangeFinder.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/restapi/change/ChangesCollection.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/javatests/com/google/gerrit/acceptance/api/change/ChangeIdIT.java
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:https://crbug.com/gerrit/11772
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/config-gerrit.txt
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/rest-api-changes.txt
[delete]https://gerrit.googlesource.com/gerrit.git/+/c9dc6e9a1177d2714a9b4850f1aef0d658f60230/java/com/google/gerrit/extensions/restapi/DeprecatedIdentifierException.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/change/ChangeFinder.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/restapi/change/ChangesCollection.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/javatests/com/google/gerrit/acceptance/api/change/ChangeIdIT.java
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:https://crbug.com/gerrit/11772
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/config-gerrit.txt
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/Documentation/rest-api-changes.txt
[delete]https://gerrit.googlesource.com/gerrit.git/+/c9dc6e9a1177d2714a9b4850f1aef0d658f60230/java/com/google/gerrit/extensions/restapi/DeprecatedIdentifierException.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/change/ChangeFinder.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/java/com/google/gerrit/server/restapi/change/ChangesCollection.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a592397ebfceaf5af8c9607673c367a7fa69af1a/javatests/com/google/gerrit/acceptance/api/change/ChangeIdIT.java
commit a592397ebfceaf5af8c9607673c367a7fa69af1a
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Feb 26 01:14:36 2020
Cancel deprecation of change identifiers
Since 2.16 the documentation of change identifiers states that the
identifiers other than "<project>~<numericid>" are deprecated and will
be removed in a future release. Since then the identifiers have still
not been removed and there is no clear plan to do so.
It is likely that "deprecated" identifiers are still used in links in
places where they can't be updated, for example in emails and forum
posts. Due to this, and since continuing to support all of the types
does not add any technical burden, ESC decided that the deprecation
should be cancelled.
Remove the deprecation notice from the documentation and remove the
change.api.allowedIdentifier setting which is now redundant.
Bug:
Change-Id: Iad8ef1d47c8b1c836bb59e3ad3ed4a3f52281294
[modify]
[modify]
[delete]
[modify]
[modify]
[modify]
da...@gmail.com
[Empty comment from Monorail migration]
da...@gmail.com
[Empty comment from Monorail migration]
ek...@google.com
[Monorail components: SteeringCommittee]
ek...@google.com
[Monorail components: -ESC]
is...@google.com
Edits were made to reflect the following in Monorail: auto-CCs.
Description
A config option allows to control which of these change identifier formats are accepted by a Gerrit server:
Issues that should be resolved:
* The deprecation was not properly discussed.
Change [1] which did the deprecation was submitted quickly without much discussion.
We didn't have an ESC back then. The ESC should discuss this now and confirm
or undo the deprecation.
* The deprecation was not announced:
If the deprecation is confirmed, it must be announced properly.
* Document strategies that admins can follow to migrate away from the
deprecated change identifier formats.
* Make a timeline for the deprecation:
This allows people to plan effort for migrating to the new format.
[1]