Obsolete
Status Update
Comments
ge...@gmail.com <ge...@gmail.com>
ge...@gmail.com <ge...@gmail.com> #2
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #3
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #4
Gerrit was using following regexp in gerrit.config:
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =https://bugs.chromium.org/p/gerrit/issues/detail?id=$2
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
ek...@google.com <ek...@google.com> #5
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #6
[Empty comment from Monorail migration]
Description
As this may also be a breaking change for some users, (e.g. long-running silent stream-events may have to handle reconnect better or change the default), this change should be handled only in a next (major) release of Gerrit, 3.1.
Therefore, a request for comments on the mailing list was posted [1]. The latter was carried out in August 2019 and received 1 positive and 0 negative responses at the time of writing. I consider this accepted, hence this tracking issue.
[1]: