Change default of sshd.idleTimeout from 0/infinity to 30 minutes [40011264]

Obsolete

Feature Request

Status Update

No update yet.

Description

ge...@gmail.com

created issue #1

Sep 20, 2019 08:31AM

Having a default value of sshd.idleTimeout of 0 (infinity) does not seem a sane default to me. Stale connections may build up over the time until Gerrit is restarted.

As this may also be a breaking change for some users, (e.g. long-running silent stream-events may have to handle reconnect better or change the default), this change should be handled only in a next (major) release of Gerrit, 3.1.

Therefore, a request for comments on the mailing list was posted [1]. The latter was carried out in August 2019 and received 1 positive and 0 negative responses at the time of writing. I consider this accepted, hence this tracking issue.

[1]:

https://groups.google.com/d/msg/repo-discuss/VZKDCIO2KRU/9gK5IegrBAAJ

Comments

ge...@gmail.com <ge...@gmail.com> Sep 20, 2019 08:31AM

Accepted by ge...@gmail.com.

ge...@gmail.com <ge...@gmail.com> #2Sep 21, 2019 06:00PM

https://gerrit-review.googlesource.com/c/gerrit/+/238376

da...@gmail.com <da...@gmail.com> #3Oct 2, 2019 03:54AM

This was discussed in yesterday's ESC meeting and we concluded that this is change that could potentially break a lot of users, so we don't want to do it for 3.1.

da...@gmail.com <da...@gmail.com> #4Jun 27, 2022 05:46AM

Status: Won't Fix (Obsolete)

[Empty comment from Monorail migration]

ek...@google.com <ek...@google.com> #5Jul 6, 2022 11:42AM

[Monorail components: Backend]

ek...@google.com <ek...@google.com> #6Jul 6, 2022 11:42AM

[Monorail components: -SSHDaemon]

Issue 40011264