Gerrit

To me, it's not only the very natural next step to make checks plugin a core plugin, but I would go even further and consider to promote checks plugin to a pure core feature, by internalizing the whole code to be a part of core Gerrit. This should significantly simplify (or even make first possible) the usage of core Gerrit infrastructure, like secondary index, NoteDb Schema migration facilities, better, while native UI integration etc.

A number of current design limitations in checks plugins are coming from its nature being a plugin and not a pure gerrit core feature.

See for example https://crbug.com/gerrit/11474 raised by OpenStack's infra team (that I totally agreed with) about missing multi repository checkers support; or this design documentation for adding sub checks feature: [1], that would probably also benefit from promoting checks plugin to core Gerrit feature (while it would certainly require some kind of NoteDb schema migration for check persistence layer).

[1] https://gerrit-review.googlesource.com/c/homepage/+/235693

Adding it as a core feature was already rejected [1] [2] but maybe it's time to revisit that.


[1] https://groups.google.com/d/msg/repo-discuss/MBYw4wM-7c8/nZS3pL5lAQAJ
[2] https://gerrit-review.googlesource.com/q/project:gerrit+topic:checkers+status:abandoned

> Adding it as a core feature was already rejected [1] [2] but maybe it's time to revisit that.

It was rejected before ESC was established. So my call is to bring the question again to the ESC to decision and re-visit CI-support as native feature in gerrit.

Making CI support a first class citizen in Gerrit is a crucial core feature that should be natively supported in Gerrit core.

We discussed this in yesterday's ESC.  Conclusion for now is to not make it a core feature (i.e. keep it as a plugin) until it's more mature.  We will revisit this in the next quarter.

I think this is obsolete, because we are not planning to invest anymore into this plugin.

What is replacing/superseding the functionality to make it obsolete?

Ah, thanks for asking. More context is at https://groups.google.com/g/repo-discuss/c/QYZFCvh_x98/m/z2uyvVrLAAAJ.

[Monorail components: SteeringCommittee]

[Monorail components: -ESC]

Edits were made to reflect the following in Monorail: auto-CCs.