Obsolete
Status Update
No update yet.
Comments
ek...@google.com
[Empty comment from Monorail migration]
ma...@gmail.com
Proposing to depend on that new upcoming Code of ours (then finish securing this issue alongside).
ek...@google.com
Google’s internal code review guidelines are now open source [1].
We should consider if we want to adopt them as best practices for contributions to the Gerrit project.
[1]https://google.github.io/eng-practices/
We should consider if we want to adopt them as best practices for contributions to the Gerrit project.
[1]
da...@gmail.com
Thanks for sharing.
+1 to adopt them as best pratices for contributions to the Gerrit project.
(We are already adopting many other standard methodologies and tools from Google, like Java style guide, Javascript style guides, Python style guides, Google Java Format, Error Prone static checker, Buildifier, IntelliJ Plugin for Bazel and others.)
+1 to adopt them as best pratices for contributions to the Gerrit project.
(We are already adopting many other standard methodologies and tools from Google, like Java style guide, Javascript style guides, Python style guides, Google Java Format, Error Prone static checker, Buildifier, IntelliJ Plugin for Bazel and others.)
ma...@gmail.com
+1
ma...@gmail.com
Tone in more recent discussions improved since; hence closing this for the time being.
ek...@google.com
[Empty comment from Monorail migration]
is...@google.com
Edits were made to reflect the following in Monorail: auto-CCs.
Description
During disagreements, communication didn't always stay respectful and each others point of view was not always valued.
We should come up with some best practices for discussions to improve our discussion culture.
This issue came up in the Community Retrospective and was also mentioned in the free form feedback of the community survey. It's likely that some of the lower rated results from the survey [1] are related to this issue.
Related to this:
*
[1]