Gerrit

Good idea!

Proposing to first do [1], to then potentially link that new Code from this reminder -indeed.

This is how it looks in Monorail:
https://imgur.com/QmatHVq

I am concerned about showing a repetitive text to all users on all comments again and again. I have scheduled the issue for discussing with UX.

I have just clicked X on the message in Monorail and it appears to be gone even when opening an issue in another tab. So maybe this is a cookie or pref? Does it come back after a while? Let me write to the Monorail team asking them about the implementation.

> I am concerned about showing a repetitive text to all users on all comments again and again.

Yes, I share this concern.

>  I have scheduled the issue for discussing with UX.

Thanks, we really want to get their expertise on this.

> I have just clicked X on the message in Monorail and it appears to be gone even when
> opening an issue in another tab. So maybe this is a cookie or pref? Does it come back
> after a while? Let me write to the Monorail team asking them about the implementation.

I haven't figured out how exactly this works in Monorail. I only see it sometimes, but not sure what are the conditions that trigger it.
Asking the Monorail team how they implemented this, is a good idea.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710

commit 500437df563f2fb7f6b30d34725f83cd7965c710
Author: Tao Zhou <taoalpha@google.com>
Date: Fri Feb 14 15:57:27 2020

Show respectful review tip when user writes comments

With a lock-up Math.max(3 days, period between creating comments),
we show this tip with a 30% probability.

When show up, it will pick tip randomly from a pre-defined list.

Once dismissed, it will add another 3 more lock up time before showing up again.

Also added interaction reports for it.

Bug: https://crbug.com/gerrit/11441
Change-Id: I6baffb7369bb2dd59716f496c389971dc7050cc8

[modify] https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.html
[modify] https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
[modify] https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_test.html
[modify] https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710/polygerrit-ui/app/elements/shared/gr-icons/gr-icons.html
[modify] https://gerrit.googlesource.com/gerrit.git/+/500437df563f2fb7f6b30d34725f83cd7965c710/polygerrit-ui/app/elements/shared/gr-storage/gr-storage.js

Is it possible to make it so the tip doesn't affect tabbing? I'm using to tabbing a certain number of times to hit [Save] and the tip seems to throw that off.

oh for sure, will skip the tip for tabs :) thx for the reporting!

https://gerrit-review.googlesource.com/c/gerrit/+/256707
this should fix for you, now the tip should not affect your tabbing any more

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit.git/+/7032792d9bbb560ad6c885eae4d09d26e8eb118a

commit 7032792d9bbb560ad6c885eae4d09d26e8eb118a
Author: Tao Zhou <taoalpha@google.com>
Date: Wed Feb 26 13:54:09 2020

Skip respectful tips for sequential keyboard navigation (tab)

Bug: https://crbug.com/gerrit/11441
Change-Id: I1874afc045557db53ca3ffaf62a72a8ccb3399df

[modify] https://gerrit.googlesource.com/gerrit.git/+/7032792d9bbb560ad6c885eae4d09d26e8eb118a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.html

Can you maybe add an option in Gerrit to opt out of these?  They're starting to wear on me.

Thanks for the feedback. Any chance you can be a bit more specific? We realize that these tips may feel slightly repetitive, but we also want to emphasize what we believe to be an important aspect for code review. You always have to option to dismiss the tip by clicking the "x", which should mute the tips for one week. Also, we are hoping to have more diverse tips in the future. Hope that helps.

I also do not like seeing these tips and would prefer to disable them outright. I dislike the tips because they are not contextually relevant: I just received one that said “DON’T: Criticize the person.” when my comment was not doing anything of the sort. The tips are not contextually relevant (i.e. they have no idea what I’m writing), and the negative ones feel like they’re attacking me for things I haven’t done.

I do not think it’s respectful of my time to have to dismiss this every 7 days. So I’ve just edited the local storage "respectfultip:visibility" timestamp via DevTools to next show these in 2120.

[Comment Deleted]

Since my witty comment about adding "DON'T: kids don't do drugs" got promptly deleted, I'll offer something more constructive: could you please add a setting to gerrit.config to disable this feature? It is of no use to us, this passive aggressiveness just irritates everyone.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Edits were made to reflect the following in Monorail: auto-CCs.