Gerrit

I would also go further and only enable the very last and recent
ES version in bazel tests per default.

All other outdated and potentially unused ES version should be
tested manually, so that

  $ bazel test javatests/...

would only run one single ES Testcontainers target and not dozen targets
for different ES versions. It could be easily achieved by splitting the rules
per ES version, and ragging all outdated and unused ES versions with
"manual".

Regarding the automated /bazel tests, I'd rather keep them all for every ES version that Gerrit still support.
Otherwise we may miss bugs with Gerrit support for some ES version(s), over time, if we're to rely on manual testing for some.

It is also hard and risky to assume which ES versions are used by the Gerrit community, and to what level.
I propose to fully stand by the versions officially supported by Gerrit.
And as Gerrit formally stops supporting any given version, then that gets done consistently like here for V5.
-More thoughts?

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65

commit 81d2b5e18ed2ff008770d00755c28c5c48e76b65
Author: David Ostrovsky <david@ostrovsky.org>
Date: Sun Apr 05 10:19:56 2020

Remove support for discontinued Elasticsearch version 5.6

According to Elasticsearch release page: [1], the support for version
5.6 was discontinued on 2019-03-11.

[1] https://www.elastic.co/support/eol

Bug: https://crbug.com/gerrit/12527
Change-Id: I1dfd9d54adcd9c92a17f478fcb3e5f3e642f9497

[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/Documentation/config-gerrit.txt
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticAccountIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticGroupIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticProjectIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticVersion.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/ActionRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/DeleteRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/IndexRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/pgm/ElasticReindexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/ssh/ElasticIndexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/BUILD
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticContainer.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticTestUtils.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryAccountsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryChangesTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryGroupsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryProjectsTest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticVersionTest.java

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65

commit 81d2b5e18ed2ff008770d00755c28c5c48e76b65
Author: David Ostrovsky <david@ostrovsky.org>
Date: Sun Apr 05 10:19:56 2020

Remove support for discontinued Elasticsearch version 5.6

According to Elasticsearch release page: [1], the support for version
5.6 was discontinued on 2019-03-11.

[1] https://www.elastic.co/support/eol

Bug: https://crbug.com/gerrit/12527
Change-Id: I1dfd9d54adcd9c92a17f478fcb3e5f3e642f9497

[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/Documentation/config-gerrit.txt
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticAccountIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticGroupIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticProjectIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticVersion.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/ActionRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/DeleteRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/IndexRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/pgm/ElasticReindexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/ssh/ElasticIndexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/BUILD
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticContainer.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticTestUtils.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryAccountsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryChangesTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryGroupsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryProjectsTest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticVersionTest.java

The following revision refers to this bug:
  https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65

commit 81d2b5e18ed2ff008770d00755c28c5c48e76b65
Author: David Ostrovsky <david@ostrovsky.org>
Date: Sun Apr 05 10:19:56 2020

Remove support for discontinued Elasticsearch version 5.6

According to Elasticsearch release page: [1], the support for version
5.6 was discontinued on 2019-03-11.

[1] https://www.elastic.co/support/eol

Bug: https://crbug.com/gerrit/12527
Change-Id: I1dfd9d54adcd9c92a17f478fcb3e5f3e642f9497

[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/Documentation/config-gerrit.txt
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/AbstractElasticIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticAccountIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticChangeIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticGroupIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticProjectIndex.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticQueryAdapter.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/ElasticVersion.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/ActionRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/DeleteRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/java/com/google/gerrit/elasticsearch/bulk/IndexRequest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/pgm/ElasticReindexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/acceptance/ssh/ElasticIndexIT.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/BUILD
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticContainer.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticTestUtils.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryAccountsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryChangesTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryGroupsTest.java
[delete] https://gerrit.googlesource.com/gerrit.git/+/2336606fb9fac86a0e74120d33a9b0d8d6bd2042/javatests/com/google/gerrit/elasticsearch/ElasticV5QueryProjectsTest.java
[modify] https://gerrit.googlesource.com/gerrit.git/+/81d2b5e18ed2ff008770d00755c28c5c48e76b65/javatests/com/google/gerrit/elasticsearch/ElasticVersionTest.java

Note: per [1] there are other versions of ES that have reached EOL:

6.0.x   2019-05-14
6.1.x   2019-06-13
6.2.x   2019-08-06
6.3.x   2019-12-13
6.4.x   2020-02-23

We should remove all EOL ES versions from the code base (also from stable branchs).

[Empty comment from Monorail migration]

I also just noticed the above list. Resumed.

[2] https://gerrit-review.googlesource.com/c/gerrit/+/262392

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Monorail components: Modules>Elasticsearch]

[Monorail components: -Elasticsearch-old]

Edits were made to reflect the following in Monorail: auto-CCs.