Fixed
Status Update
Comments
da...@gmail.com <da...@gmail.com> #2
[Empty comment from Monorail migration]
jr...@google.com <jr...@google.com> #3
What are the remaining steps before we can announce and release this?
Is this waiting on somebody verifying the changes athttps://gerrit-review.googlesource.com/q/hashtag :"jgitupgradedec2018"?
Is this waiting on somebody verifying the changes at
jr...@google.com <jr...@google.com> #4
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #5
[Empty comment from Monorail migration]
jr...@google.com <jr...@google.com> #6
da...@gmail.com <da...@gmail.com> #7
Sorry about that. I've added you as reviewer on the other changes in that set.
da...@gmail.com <da...@gmail.com> #8
> Is this waiting on somebody verifying the changes at https://gerrit-review.googlesource.com/q/hashtag :"jgitupgradedec2018"?
Yes.
Given that it's the same fix in all of them, it should be safe enough to verify on one of them and then carry the score over to all the others.
I can try to test it tomorrow if you can provide steps how to do it.
It would be better though if we can write an integration test on the earliest stable branch and then merge that up through the subsequent branches.
Yes.
Given that it's the same fix in all of them, it should be safe enough to verify on one of them and then carry the score over to all the others.
I can try to test it tomorrow if you can provide steps how to do it.
It would be better though if we can write an integration test on the earliest stable branch and then merge that up through the subsequent branches.
da...@gmail.com <da...@gmail.com> #9
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #10
Removing the visibility restriction now that the issue is fixed.
da...@gmail.com <da...@gmail.com> #11
[Empty comment from Monorail migration]
ba...@gmail.com <ba...@gmail.com> #12
[Comment Deleted]
ek...@google.com <ek...@google.com> #13
[Monorail components: Backend]
Description
*****************************************************************
***** *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!! *****
***** *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD, *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
***** *****
***** THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS *****
***** *****
*****************************************************************
Affected Version: 2.9 and later
As reported by Jonathan Nieder:
In protocol v0 bidirectional transports, the AdvertiseRefsHook is called at ref advertisement time and all is well. But in protocol v0 HTTP, we're not seeing the AdvertiseRefsHook called anywhere for the /git-upload-pack request, meaning that wants aren't validated and I can fetch anything that is pointed to by any ref (using fetch-by-sha1), as long as I can guess the object name.