Status Update
No update yet.
Comments
th...@yahoo.com
[Empty comment from Monorail migration]
jr...@google.com
Is it worth fixing the migration, or should we drop the migrations from versions before 2.15?
da...@gmail.com
I think it would be worth fixing the migration, if possible.
How feasible would it be to do that?
How feasible would it be to do that?
ma...@gmail.com
Agree. We cannot drop the ability to migrate from 2.14 to 2.15 or 2.16.
There are still production deployments on 2.14, like Ericsson's, potentially among others.
Migrating from 2.14 onwards could require the 2.15 intermediary step, though.
That is anyway less risky than trying to skim 2.15 when migrating to 2.16.
There are still production deployments on 2.14, like Ericsson's, potentially among others.
Migrating from 2.14 onwards could require the 2.15 intermediary step, though.
That is anyway less risky than trying to skim 2.15 when migrating to 2.16.
da...@gmail.com
As far as I understand, the problem is that all of the schema updates are done in sequence, and then all of the migrations are done in sequence. This means that if a schema update removes a column it cannot then be referenced in any of the later migrations.
da...@gmail.com
[Empty comment from Monorail migration]
lu...@gmail.com
AFAIK, createdOn in AccountsGroup wasn't dropped. Looks like a GWTORM hiccup to me, as the column should have been created.
However, your workaround seems to work :-)
However, your workaround seems to work :-)
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:https://crbug.com/gerrit/10248
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/java/com/google/gerrit/server/schema/Schema_151.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/javatests/com/google/gerrit/server/schema/Schema_150_to_151_Test.java
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]
[modify]
da...@gmail.com
[Empty comment from Monorail migration]
da...@gmail.com
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:https://crbug.com/gerrit/10248
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/java/com/google/gerrit/server/schema/Schema_151.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/javatests/com/google/gerrit/server/schema/Schema_150_to_151_Test.java
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:https://crbug.com/gerrit/10248
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/java/com/google/gerrit/server/schema/Schema_151.java
[modify]https://gerrit.googlesource.com/gerrit.git/+/a009567e10f9a29e797ec6c66c07cb0397523d88/javatests/com/google/gerrit/server/schema/Schema_150_to_151_Test.java
commit a009567e10f9a29e797ec6c66c07cb0397523d88
Author: David Pursehouse <dpursehouse@collab.net>
Date: Wed Mar 18 13:16:08 2020
Schema_151: Attempt to add created_on column if it doesn't exist
If the created_on column does not exist, attempt to create it.
This allows the direct migration from 2.14 to 2.16 to succeed
without requiring an intermediate migration to 2.15.
Bug:
Change-Id: I626f1e26d43b60c3fd62ef3ef9ce3d7047c1a383
[modify]
[modify]
Description
Affected Version: 2.16.2
What steps will reproduce the problem?
1. java -jar gerrit.war init -d /gerrit
What is the expected output?https://www.gerritcodereview.com/2.16.html .
A successful schema migration, as described in
What do you see instead?
Migrating data to schema 151 ...
Exception in thread "main" com.google.gwtorm.server.OrmException: Cannot upgrade schema
at com.google.gerrit.server.schema.SchemaUpdater.update(SchemaUpdater.java:113)
at com.google.gerrit.pgm.init.BaseInit$SiteRun.upgradeSchema(BaseInit.java:383)
[...]
Caused by: org.postgresql.util.PSQLException: ERROR: column "created_on" of relation "account_groups" does not exist
Please provide any additional information below.https://groups.google.com/forum/#!topic/repo-discuss/FPfy_Ng8eGQ .https://groups.google.com/forum/#!topic/repo-discuss/jv5FrOmxNOY
Based on a report by Mike Lupo at
Later reported again by Mohamed at