Feature Request P2
Status Update
No update yet.
Comments
wy...@google.com
[Empty comment from Monorail migration]
ka...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
ka...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
lo...@google.com
[Empty comment from Monorail migration]
ka...@google.com
[Empty comment from Monorail migration]
ka...@google.com
From 8788:
I often have this workflow:
* CL author uploads patch set 1
* I comment on patch set 1
* Author replies the comment, uploads a new patch set
* I open the comment thread on patch set 1 to read the reply
* Now I want to compare the last patch set to the one I commented on.
So, essentially I want to switch from a base..1 diff to 1..2 (assuming 2 is the latest patch set), but it currently requires two interactions (base..1 -> base..2 -> 1..2), they have to be in the correct order because Gerrit doesn't allow the same patch set on both sides, and I have to remember the old patch set number because the intermediate step loses that information. Having a single button to do this would be very nice :)
I often have this workflow:
* CL author uploads patch set 1
* I comment on patch set 1
* Author replies the comment, uploads a new patch set
* I open the comment thread on patch set 1 to read the reply
* Now I want to compare the last patch set to the one I commented on.
So, essentially I want to switch from a base..1 diff to 1..2 (assuming 2 is the latest patch set), but it currently requires two interactions (base..1 -> base..2 -> 1..2), they have to be in the correct order because Gerrit doesn't allow the same patch set on both sides, and I have to remember the old patch set number because the intermediate step loses that information. Having a single button to do this would be very nice :)
ke...@google.com
+1 - I run into this about 2x / day. Every time I have to rejigger the patch selection in the diff view, I wonder why the Gerrit default isn't what's suggested in this thread.
Even having a convenient button to do just "show diff between newest patch I commented on and latest patch" would go a long way. The problem is that you have to do two clicks to get this operation done, since gerrit disallows selecting the same patch on both sides of the diff.
Even having a convenient button to do just "show diff between newest patch I commented on and latest patch" would go a long way. The problem is that you have to do two clicks to get this operation done, since gerrit disallows selecting the same patch on both sides of the diff.
ke...@google.com
Just wanted to bump this issue again. This is a multiple times per day issue for myself and every one on my team.
br...@google.com
We are actively working on this. You can follow https://gerrit-review.googlesource.com/c/gerrit/+/264833 . It should land later this quarter.
is...@google.com
Edits were made to reflect the following in Monorail: auto-CCs.
Description
It would also be helpful to have "diff with Base" and "diff with Latest" links. Fiddling with the patch set drop-down menus to change from Base -> N to N -> Latest is way too painful (especially when I accidentally click the Base drop-down first, because I can't select N until the right-hand side has been moved from N to Latest).