Fixed
Status Update
Comments
xc...@google.com <xc...@google.com> #2
I have imported Mockito to gerrit WORKSPACE and migrate EasyMock to Mockito for a packages. More migration work will be done in latter changes. And finally we may not relay on EasyMock any more. We should migrate PowerMock to Mockito, too.
hi...@google.com <hi...@google.com> #3
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #4
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #5
Changcheng's original change to migrate from easymock to mockito [1] got abandoned after inactivity.
In the meantime we added a dependency on mockito [2] when the delete-project plugin was promoted to a core plugin.
So now we have two mock frameworks in core, although mockito is currently only available to the core plugins. There is a change proposed by David Ostrovsky [3] to make mockito available to all plugins.
[1]https://gerrit-review.googlesource.com/c/gerrit/+/93405
[2]https://gerrit-review.googlesource.com/c/gerrit/+/203712
[3]https://gerrit-review.googlesource.com/c/gerrit/+/225875
In the meantime we added a dependency on mockito [2] when the delete-project plugin was promoted to a core plugin.
So now we have two mock frameworks in core, although mockito is currently only available to the core plugins. There is a change proposed by David Ostrovsky [3] to make mockito available to all plugins.
[1]
[2]
[3]
ma...@gmail.com <ma...@gmail.com> #6
da...@gmail.com <da...@gmail.com> #7
We decided in yesterday's ESC meeting to switch to mockito.
da...@gmail.com <da...@gmail.com> #8
There are several test classes using easymock. I think it will be better to migrate them one by one to make reviewing easier.
I've uploaded the first one with the hashtag 'easymock-to-mockito', and will use the same hashtag for subsequent changes.
https://gerrit-review.googlesource.com/q/status:open+hashtag:easymock-to-mockito
I've uploaded the first one with the hashtag 'easymock-to-mockito', and will use the same hashtag for subsequent changes.
da...@gmail.com <da...@gmail.com> #9
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #10
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #11
[Monorail components: Backend]
Description
*****************************************************************
***** *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!! *****
***** *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD, *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
***** *****
***** THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS *****
***** *****
*****************************************************************
Affected Version: All
What is the expected output?
Use Mockito instead of EasyMock
What do you see instead?
Please provide any additional information below.