Fixed
Status Update
No update yet.
Comments
ed...@gmail.com
je...@gmail.com
Yes, now it is reactivated and the gerrit jenkins plugin is working again.
But the documentation is not clear about the --verified option.
And a more explicit note should be added on the website.
There is no informations related to this "incompatibility" either on the gerrit website or on the gerrit jenkins plugin website.
But the documentation is not clear about the --verified option.
And a more explicit note should be added on the website.
There is no informations related to this "incompatibility" either on the gerrit website or on the gerrit jenkins plugin website.
ed...@gmail.com
> But the documentation is not clear about the --verified option.
Already done
https://gerrit-review.googlesource.com/51800
> And a more explicit note should be added on the website.
This is part of the 2.6 release notes:
https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.6.html#_labels
Already done
> And a more explicit note should be added on the website.
This is part of the 2.6 release notes:
je...@gmail.com
Thanks for the clarification of the doc.
But for the release not, when you install directly the 2.8, there is no informations related to problems with plugins (I also filled a bug report for gerrit / jenkins).
Something more explicit should be added to all the release notes from 2.6 to 2.8.1.
But for the release not, when you install directly the 2.8, there is no informations related to problems with plugins (I also filled a bug report for gerrit / jenkins).
Something more explicit should be added to all the release notes from 2.6 to 2.8.1.
ed...@gmail.com
> when you install directly the 2.8
When you install 2.8 directly you likly read the 2.8 documentation where this is mentioned
https://gerrit-documentation.storage.googleapis.com/Documentation/2.8/config-labels.html#label_Verified
> Something more explicit should be added to all the release notes from 2.6 to 2.8.1.
No. I agree the warning should be more explicit in the 2.6 release notes, but the release notes of a release should only contain things that changed in that release and not repeat information from earlier releases.
When you install 2.8 directly you likly read the 2.8 documentation where this is mentioned
> Something more explicit should be added to all the release notes from 2.6 to 2.8.1.
No. I agree the warning should be more explicit in the 2.6 release notes, but the release notes of a release should only contain things that changed in that release and not repeat information from earlier releases.
ed...@gmail.com
[Empty comment from Monorail migration]
ed...@gmail.com
[Empty comment from Monorail migration]
za...@gmail.com
[Comment Deleted]
ek...@google.com
[Monorail components: Backend]
Description
In the documentation, there is a --verified option for the command 'gerrit review'.
When I enter the following command:
ssh -p 29418 jenkins@192.168.0.18 gerrit review --project TestGerrit --code-review 0 2,1
Everything is fine.
But when I enter the following command:
ssh -p 29418 jenkins@192.168.0.18 gerrit review --project TestGerrit --verified 1 --core-review 0 2,1
An error is displayed:
fatal: "--verified" is not a valid option
I think this is why the gerrit / jenkins plugin is hanging ... It still needs to send a --verified option which make the jenkins submission fails.