Assigned
Status Update
Comments
so...@google.com <so...@google.com> #2
[Empty comment from Monorail migration]
mi...@gmail.com <mi...@gmail.com> #3
[Empty comment from Monorail migration]
so...@google.com <so...@google.com> #4
Gerrit was using following regexp in gerrit.config:
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =https://bugs.chromium.org/p/gerrit/issues/detail?id=$2
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
[commentlink "ph"]
match = "([Bb]ug|[Ii]ssue)\\s*#?(\\d+)"
link =
\\s matches \n and \r so \\s* will match a lot of new lines
[ \\t]*\\r\\n?[ \\t]* matches just one new line
od...@gmail.com <od...@gmail.com> #5
[Empty comment from Monorail migration]
jt...@gmail.com <jt...@gmail.com> #6
[Empty comment from Monorail migration]
so...@google.com <so...@google.com> #7
Edits were made to reflect the following in Monorail: auto-CCs.
bb...@gmail.com <bb...@gmail.com> #8
For my own purpose I created the server side part, it's now easy to link it to a button. I'm not familiar in pushing gerrit code, but I accepted the NDA and stuff. Should I proceed?
bb...@gmail.com <bb...@gmail.com> #10
[Comment Deleted]
bb...@gmail.com <bb...@gmail.com> #11
Thanks for help, done:
https://review.source.android.com/#change,22779
Please note that the instruction are missing the important bit about the change-id:
http://gerrit.googlecode.com/svn/documentation/2.1.2/user-upload.html#push_create
A special hook must be loaded on your local repo if you want to create a new patch so that it will generate inside the commit message the necessary change-id
The instructions are also missing the username in the "review" alias. Instead of this:
git config remote.review.url ssh://review.source.android.com:29418/tools/gerrit.git
It shoud be this:
git config remote.review.url ssh://yourusername@review.source.android.com:29418/tools/gerrit.git
Please note that the instruction are missing the important bit about the change-id:
A special hook must be loaded on your local repo if you want to create a new patch so that it will generate inside the commit message the necessary change-id
The instructions are also missing the username in the "review" alias. Instead of this:
git config remote.review.url ssh://
It shoud be this:
git config remote.review.url ssh://
sw...@gmail.com <sw...@gmail.com> #12
Does this feature have plan? not only I want to delete group from web page, but I want to delete user.
ss...@gmail.com <ss...@gmail.com> #13
Is anyone still actively working on this feature? The change from #10 does not seem to exists anymore at least.
ed...@gmail.com <ed...@gmail.com> #14
No, AFAIK nobody is working on this.
bu...@gmail.com <bu...@gmail.com> #15
It would be great if REST APIs could also support the group deletion in addition to UI.
lo...@google.com <lo...@google.com> #16
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #17
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #18
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #20
[Empty comment from Monorail migration]
da...@gmail.com <da...@gmail.com> #21
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #22
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #23
[Empty comment from Monorail migration]
ek...@google.com <ek...@google.com> #24
[Monorail components: Backend]
ek...@google.com <ek...@google.com> #25
[Empty comment from Monorail migration]
ap...@google.com <ap...@google.com> #28
Project: gerrit
Branch: master
Author: Phan Tran Tuan Khai <
Link:
Support of group deletion via REST
Expand for full commit details
Support of group deletion via REST
A group can now be removed by DELETE on '/groups/<group>'.
The implementation includes sanity checks that it is possible to
delete the group:
- The calling user is an administrator
- The given group is not a system group
- The given group is an internal group (it is assumed that we will not
allow to delete external groups)
- The given group is not the owner of any other group(s)
- Check that the group is not used in ref permissions
- Actually delete the group
- Add documentation
ESC meeting minutes: https://www.gerritcodereview.com/2019-10-01-esc-minutes.html#support-for-deletion-of-groups
Release-Notes: Implement a new REST-API to remove Gerrit groups
Feature: Issue 40000131
Change-Id: I4ca85843f6d24740d1431f5cdd4462e4ffc0bd0c
Files:
- M
Documentation/config-gerrit.txt
- M
Documentation/rest-api-groups.txt
- M
java/com/google/gerrit/extensions/api/groups/GroupApi.java
- A
java/com/google/gerrit/extensions/common/DeleteGroupInput.java
- M
java/com/google/gerrit/server/account/GroupControl.java
- M
java/com/google/gerrit/server/api/groups/GroupApiImpl.java
- M
java/com/google/gerrit/server/group/db/GroupNameNotes.java
- M
java/com/google/gerrit/server/group/db/GroupsUpdate.java
- M
java/com/google/gerrit/server/restapi/RestApiModule.java
- A
java/com/google/gerrit/server/restapi/group/DeleteGroup.java
- M
java/com/google/gerrit/server/restapi/group/GroupRestApiModule.java
- M
javatests/com/google/gerrit/acceptance/api/group/GroupsIT.java
Hash: 8463fb9c9d90dd8a8792cc861a84796528b893b1
Date: Mon May 29 02:34:53 2023
Description
Source: JIRA GERRIT-44
Affected Version: 2.0
Users (or at least Administrators) should be able to delete groups through the
web UI, especially if the group is never used in a ProjectRight entity and
also is not the owner of another group or a project.