Assigned
Status Update
No update yet.
Comments
so...@google.com
[Empty comment from Monorail migration]
mi...@gmail.com
Is there a way to do this until implemented in the web UI?
so...@google.com
Not really.
DELETE FROM account_groups WHERE name='...';
DELETE FROM account_group_names
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
And then you might want to clean up the database a bit
to remove the now orphaned records:
DELETE FROM account_group_members
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
DELETE FROM account_group_members_audit
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
% or project_rights
DELETE FROM ref_rights WHERE
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
DELETE FROM account_groups WHERE name='...';
DELETE FROM account_group_names
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
And then you might want to clean up the database a bit
to remove the now orphaned records:
DELETE FROM account_group_members
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
DELETE FROM account_group_members_audit
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
% or project_rights
DELETE FROM ref_rights WHERE
WHERE group_id NOT IN (SELECT group_id FROM account_groups);
od...@gmail.com
Perhaps priority of this should be bumped up a bit considering https://crbug.com/gerrit/48 means that
any registered user can create "SPAM" groups and there is no way to delete them.
any registered user can create "SPAM" groups and there is no way to delete them.
jt...@gmail.com
Any interest in this still?
so...@google.com
Yes, we just need to write it. :-(
bb...@gmail.com
For my own purpose I created the server side part, it's now easy to link it to a button. I'm not familiar in pushing gerrit code, but I accepted the NDA and stuff. Should I proceed?
bb...@gmail.com
[Comment Deleted]
bb...@gmail.com
Thanks for help, done:
https://review.source.android.com/#change,22779
Please note that the instruction are missing the important bit about the change-id:
http://gerrit.googlecode.com/svn/documentation/2.1.2/user-upload.html#push_create
A special hook must be loaded on your local repo if you want to create a new patch so that it will generate inside the commit message the necessary change-id
The instructions are also missing the username in the "review" alias. Instead of this:
git config remote.review.url ssh://review.source.android.com:29418/tools/gerrit.git
It shoud be this:
git config remote.review.url ssh://yourusername@review.source.android.com:29418/tools/gerrit.git
Please note that the instruction are missing the important bit about the change-id:
A special hook must be loaded on your local repo if you want to create a new patch so that it will generate inside the commit message the necessary change-id
The instructions are also missing the username in the "review" alias. Instead of this:
git config remote.review.url ssh://
It shoud be this:
git config remote.review.url ssh://
sw...@gmail.com
Does this feature have plan? not only I want to delete group from web page, but I want to delete user.
ss...@gmail.com
Is anyone still actively working on this feature? The change from #10 does not seem to exists anymore at least.
ed...@gmail.com
No, AFAIK nobody is working on this.
bu...@gmail.com
It would be great if REST APIs could also support the group deletion in addition to UI.
lo...@google.com
[Empty comment from Monorail migration]
da...@gmail.com
[Empty comment from Monorail migration]
da...@gmail.com
[Empty comment from Monorail migration]
ek...@google.com
[Empty comment from Monorail migration]
da...@gmail.com
[Empty comment from Monorail migration]
ek...@google.com
[Empty comment from Monorail migration]
ek...@google.com
[Empty comment from Monorail migration]
ek...@google.com
[Monorail components: Backend]
ek...@google.com
[Empty comment from Monorail migration]
ap...@google.com
Project: gerrit
Branch: master
Author: Phan Tran Tuan Khai <
Link:
Support of group deletion via REST
Expand for full commit details
Support of group deletion via REST
A group can now be removed by DELETE on '/groups/<group>'.
The implementation includes sanity checks that it is possible to
delete the group:
- The calling user is an administrator
- The given group is not a system group
- The given group is an internal group (it is assumed that we will not
allow to delete external groups)
- The given group is not the owner of any other group(s)
- Check that the group is not used in ref permissions
- Actually delete the group
- Add documentation
ESC meeting minutes: https://www.gerritcodereview.com/2019-10-01-esc-minutes.html#support-for-deletion-of-groups
Release-Notes: Implement a new REST-API to remove Gerrit groups
Feature: Issue 40000131
Change-Id: I4ca85843f6d24740d1431f5cdd4462e4ffc0bd0c
Files:
- M
Documentation/config-gerrit.txt - M
Documentation/rest-api-groups.txt - M
java/com/google/gerrit/extensions/api/groups/GroupApi.java - A
java/com/google/gerrit/extensions/common/DeleteGroupInput.java - M
java/com/google/gerrit/server/account/GroupControl.java - M
java/com/google/gerrit/server/api/groups/GroupApiImpl.java - M
java/com/google/gerrit/server/group/db/GroupNameNotes.java - M
java/com/google/gerrit/server/group/db/GroupsUpdate.java - M
java/com/google/gerrit/server/restapi/RestApiModule.java - A
java/com/google/gerrit/server/restapi/group/DeleteGroup.java - M
java/com/google/gerrit/server/restapi/group/GroupRestApiModule.java - M
javatests/com/google/gerrit/acceptance/api/group/GroupsIT.java
Hash: 8463fb9c9d90dd8a8792cc861a84796528b893b1
Date: Mon May 29 02:34:53 2023
Description
Source: JIRA GERRIT-44
Affected Version: 2.0
Users (or at least Administrators) should be able to delete groups through the
web UI, especially if the group is never used in a ProjectRight entity and
also is not the owner of another group or a project.