Gerrit

Hi Nasser, The comment you are trying to publish was created on the 7th of November:

commit aef9a6611d57d829f47b11f3c487d3ab11e4e2d9 (refs/draft-comments/34/1203734/1022030)
Author: Gerrit User 1022030 <1022030@d5d70762-12d0-45a1-890d-524b12d3f735>
Date:   Thu Nov 7 19:54:39 2024 +0000

    Update draft comments

You have then published the draft comments on the 14th of November on review.gerrithub.io:

pull_replication_log.2024-11-14.gz:[2024-11-14 23:14:47,597] Ref event received: DELETE on project All-Users:refs/draft-comments/34/1203734/1022030 - aef9a6611d57d829f47b11f3c487d3ab11e4e2d9 => 0000000000000000000000000000000000000000

Because of a bug on the multi-site plugin that I've found and fixed a couple of weeks ago, the publishing of the drafts was not replicated on the other sites. Hence, you still see your draft comments on eclipse.gerrithub.io.

I've removed them manually now, and you shouldn't see them anymore.

Let me double-check.

This new comment has been published on eclipse.gerrithub.io yesterday:

sharedref_log.2024-11-20.gz:[2024-11-20 05:14:24,306] [FanOut-1[com.google.gerrit.server.notedb.AllUsersAsyncUpdate$$Lambda$5753/0x00007f8a1d478b58@1f146bf1]] INFO  : {"ref_name":"refs/draft-comments/44/1202844/1022030","old_id":"9416130cb8257a340bb8aa887802d45d09a6af68","project_name":"All-Users","type":"DELETE_REF"}

I haven't rolled out yet the fix for the draft comments publishing to all sites, unfortunately.

If you try to do the same on https://eclipse.gerrithub.io instead of https://review.gerrithub.io it will work.

Thanks. If it helps, this is what I get when I copy the request as cURL from Chrome dev tools:

curl 'https://review.gerrithub.io/changes/eclipse-jgit%2Fjgit~1202844/revisions/11/drafts' \
  -X 'PUT' \
  -H 'accept: */*' \
  -H 'accept-language: en-US,en;q=0.9' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'cookie: scope=scopes; GerritAccount=<redacted>; XSRF_TOKEN=<redacted>; JSESSIONID=<redacted> \
  -H 'origin: https://review.gerrithub.io' \
  -H 'pragma: no-cache' \
  -H 'priority: u=1, i' \
  -H 'sec-ch-ua: "Chromium";v="130", "Google Chrome";v="130", "Not?A_Brand";v="99"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: same-origin' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36' \
  -H 'x-gerrit-auth: <redacted>' \
  --data-raw '{"message":"nit: should be `packs`\n\n```suggestion\n\t * tag refs into packed-refs. If {@code all} flag is set, this packs all the\n```","unresolved":true,"path":"org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectory.java","side":"REVISION","line":296,"range":{"start_line":296,"start_character":64,"end_line":296,"end_character":68}}'

If you try to do the same on https://eclipse.gerrithub.io instead of https://review.gerrithub.io it will work.

Nice, that worked! https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1202844/comment/95c91373_4a612f4f/

I'm doing an emergency upgrade of the 1st site serving https://review.gerrithub.io so that this problem won't happen again when you switch between sites. I did already that upgrade on a canary site and worked fine.

Does this issue also affect has:draft somehow? I'm seeing on both eclipse.gerrithub.io and review.gerrithub.io that https://eclipse.gerrithub.io/q/has:draft+-is:open returns 2 changes, but neither has a draft comment.

I also have non-existing draft comments listed for the following changes: 1199465 1201738 1203402

@Matthias @Nasser yes, it does affect them. It's a long story that started when we realised that Gerrit was missing events for draft comments. As soon as the rollout is complete on all sites, this problem will finally disappear :-)