SSHD timeout configurations are multiplied by 1000 [365889749]

Fixed

Bug

Status Update

No update yet.

Description

nk...@gmail.com

created issue #1

Sep 11, 2024 08:30AM

*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!! *** Do not submit bugs for chrome/android and issues with your company's *** Gerrit setup here. Those issues belong in different issue trackers.

What steps will reproduce the problem?

Clone a repository having 200+ megabytes of size, on windows where not enough disk space is available. Clone will fail
Use Gerrit show-queue to see that the git-upload-pack is stuck even after sshd.idleTimeout expired.

What is the expected output?

Connection should go away after configured timeout

What do you see instead?

The connection goes away only after 1000 times the configured idle timeout.

Please provide any additional information below.

The repository size 200+ mb is mentioned just to be sure that issue is visible because for very small repos I didn't see the issue.

Comments

nk...@gmail.com <nk...@gmail.com> #2Sep 11, 2024 08:40AM

Proposed fix: https://gerrit-review.googlesource.com/c/gerrit/+/436759

ap...@google.com <ap...@google.com> #3Dec 16, 2024 12:37PM

Project: gerrit
Branch: master
Author: Narendra Kumar <nknkchoudhary@gmail.com>
Link: https://gerrit-review.googlesource.com/436759

Fix timeouts calculation in SshDaemon

Expand for full commit details

Fix timeouts calculation in SshDaemon 
 
In the change [1] a bug has been introduced. 
The timeouts were multiplied by one thousand while preserving the time 
unit. For example, if sshd.idleTimeout was set to one minute in gerrit 
config then it became 1000 minutes. For this reason the idle 
connections were not terminated for a long time. For example, 
idleTimeout=5m caused idle connections staying up for days. 
 
[1] Ia4f033269440fe7e1ecc268c10b1fbd97631484c 
 
Bug: Issue 365889749 
Release-Notes: Fix timeouts calculation in SshDaemon 
Change-Id: I2f1cfb265d6be84bfbc9c376f58e0a43d8f0e40d

Files:

M java/com/google/gerrit/sshd/SshDaemon.java

Hash: 44a97a1c543a740cdd331aa945c9c5d33f13b772
Date: Wed Sep 11 10:05:41 2024

sy...@gmail.com <sy...@gmail.com> Jan 13, 2025 04:00PM

Marked as fixed, reassigned to sy...@gmail.com.

ap...@google.com <ap...@google.com> #4Jan 17, 2025 11:47PM

Project: gerrit
Branch: stable-3.4
Author: Narendra Kumar <nknkchoudhary@gmail.com>
Link: https://gerrit-review.googlesource.com/447622

Fix timeouts calculation in SshDaemon

Expand for full commit details

Fix timeouts calculation in SshDaemon 
 
In the change [1] a bug has been introduced. 
The timeouts were multiplied by one thousand while preserving the time 
unit. For example, if sshd.idleTimeout was set to one minute in gerrit 
config then it became 1000 minutes. For this reason the idle 
connections were not terminated for a long time. For example, 
idleTimeout=5m caused idle connections staying up for days. 
 
[1] Ia4f033269440fe7e1ecc268c10b1fbd97631484c 
 
Bug: Issue 365889749 
Release-Notes: Fix timeouts calculation in SshDaemon 
Change-Id: I2f1cfb265d6be84bfbc9c376f58e0a43d8f0e40d 
(cherry picked from commit 44a97a1c543a740cdd331aa945c9c5d33f13b772)

Files:

M java/com/google/gerrit/sshd/SshDaemon.java

Hash: dd0ab802c36dd0b059f0f5eb018ce294a8bfc0ec
Date: Wed Sep 11 10:05:41 2024

Issue 365889749

Description

Issue summary

Comments

nk...@gmail.com <nk...@gmail.com> #2Sep 11, 2024 08:40AM

ap...@google.com <ap...@google.com> #3Dec 16, 2024 12:37PM

sy...@gmail.com <sy...@gmail.com> Jan 13, 2025 04:00PM

ap...@google.com <ap...@google.com> #4Jan 17, 2025 11:47PM

Add comment

Issue metadata