Fixed
Status Update
Comments
sy...@gmail.com <sy...@gmail.com> #2
Ok, here is a fix:
422524: Fix vertical alignment of header icon and text |
I have spent enough time to fully understand what is going on, so I could as well fix the issue. :-) What convinced me is that even all the current installations (e.g. chromium-review) have improved. So this was not just a feature request for using other icon sizes, but this was an alignment bug everywhere, even though it mostly matters just 1 or 2 pixels.
ap...@google.com <ap...@google.com> #3
Thanks Ben :)
Description
What steps will reproduce the problem?
DynamicItem
. You can build it in-tree by issuing:error_log
(or stdout) and notice how it shows the item bounded by the plugin, every 5 seconds:Notice how
ItemBoundByPlugin
is still correctly bound.Disable the plugin
What is the expected output?
the
ItemBoundByPlugin
should be de-registered and the default implementation should be bound instead. In this case, that's theDefaultProjectNameLockManager
.What do you see instead?
The
ItemBoundByPlugin
is still bounded, and it is not de-registered, a.k.a. you can still see in the logs:** Notes **
This seems to be related to an old refactoring of the
Plugin
classes [1], which caused the incorrect duplication of thereloadableRegistrationHandles
instance.This is preventing the DynamicItem from being correctly hot-swapped to the new plugin during the reload and instead a new one is created, leaving the old DynamicItem bound class around.
[1]https://gerrit-review.googlesource.com/c/gerrit/+/39270