Verified
Status Update
No update yet.
Comments
sv...@axis.com
sv...@axis.com
ap...@google.com
Project: gerrit
Branch: stable-3.8
commit 76658dab4321ae0d81aaf6c38d56a271bfe887e1
Author: Sven Selberg <svense@axis.com>
Date: Tue Jun 04 08:06:21 2024
Only show matching hashtags as suggests
The current behavior is to show all hashtags from changes that has one
hashtag that matches input. For a server that has wide use of hashtags
this is less helpful since a majority of the suggested hashtags aren't
matching the input.
Filter the array of existing hashtags for those matching the input.
Solves:
Change-Id: I7d75184594e925890860c84c156aee86eb782a08
Release-Notes: Only suggest matching hashtags.
M polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.ts
https://gerrit-review.googlesource.com/428377
Branch: stable-3.8
commit 76658dab4321ae0d81aaf6c38d56a271bfe887e1
Author: Sven Selberg <svense@axis.com>
Date: Tue Jun 04 08:06:21 2024
Only show matching hashtags as suggests
The current behavior is to show all hashtags from changes that has one
hashtag that matches input. For a server that has wide use of hashtags
this is less helpful since a majority of the suggested hashtags aren't
matching the input.
Filter the array of existing hashtags for those matching the input.
Solves:
Change-Id: I7d75184594e925890860c84c156aee86eb782a08
Release-Notes: Only suggest matching hashtags.
M polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.ts
sv...@axis.com
sv...@axis.com
It was actually Rikard Almgren that verified, thanks Rikard!
sv...@axis.com
Missed the fact that inhashtags supports regexp, my fix effectively removes the regex functionality since it does a substring match, should be:
.then(response =>
(response ?? [])
.flatMap(change => change.hashtags ?? [])
.filter(isDefined)
.filter(unique)
.filter(hashtag => hashtag.includes(input) || hashtag.match(input))
.map(hashtag => {
return {name: hashtag, value: hashtag};
})
);
ap...@google.com
Project: gerrit
Branch: stable-3.8
commit 4312d4d00ad3e6d2cf261d7b670c27bea5bf7c51
Author: David Åkerman <davidak@axis.com>
Date: Wed Jun 05 10:50:22 2024
Match hashtags suggestions with regex as well
In previous change 428377 we missed to handle the case
where the input is a regex. This will fix that.
Solves:
Release-Notes: skip
Change-Id: I8f1588c09459c76e888b22b7f992b9a8f0064c99
M polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.ts
https://gerrit-review.googlesource.com/428559
Branch: stable-3.8
commit 4312d4d00ad3e6d2cf261d7b670c27bea5bf7c51
Author: David Åkerman <davidak@axis.com>
Date: Wed Jun 05 10:50:22 2024
Match hashtags suggestions with regex as well
In previous change 428377 we missed to handle the case
where the input is a regex. This will fix that.
Solves:
Release-Notes: skip
Change-Id: I8f1588c09459c76e888b22b7f992b9a8f0064c99
M polygerrit-ui/app/elements/change/gr-change-metadata/gr-change-metadata.ts
Description
What steps will reproduce the problem?
1. Create change and give it three hastags ["lemon", "apple", "kiwi"]
2. Create another change and enter "lem" in the hashtag input.
3.
What is the expected output?
The suggest should be:
* lemon
What do you see instead?
Suggest is:
* lemon
* apple
* kiwi
What is the output of the JS console log (if applicable)?
What is the performance record (see
Please provide any additional information below.
The hashtag suggest currently looks for changes with similar hashtags and uses ALL hashtags from those changes regardless of whether they match the input or not.
Functionality is identical to the topic suggest but since there can only be 1 topic / change the topic suggest works perfect.