Bug P3
Status Update
No update yet.
Comments
ap...@google.com
Project: gerrit
Branch: stable-3.4
commit 1fbd90da749cc80c115f745e458cea31d0bb5dec
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Tue Mar 19 15:58:18 2024
Fix paginationType NONE to run further queries only if needed
If the first query to the index did not fill the full limit the caller
wants, we paginate to obtain more results. However, subsequent queries
are not needed if the previous query returned less results
than the limit.
This is a follow up of the change 413358 [1], that has reintroduced the
issue fixed in change 344695.
[1]:https://gerrit-review.googlesource.com/c/gerrit/+/413358/comment/85bca522_2b3552b2/
Bug:
Release-Notes: Fix pagination to stop querying when there are no more results
Change-Id: Ie326f3628f5312a83bf83177a3fa5134f042b59a
M java/com/google/gerrit/index/query/PaginatingSource.java
https://gerrit-review.googlesource.com/414699
Branch: stable-3.4
commit 1fbd90da749cc80c115f745e458cea31d0bb5dec
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Tue Mar 19 15:58:18 2024
Fix paginationType NONE to run further queries only if needed
If the first query to the index did not fill the full limit the caller
wants, we paginate to obtain more results. However, subsequent queries
are not needed if the previous query returned less results
than the limit.
This is a follow up of the change 413358 [1], that has reintroduced the
issue fixed in change 344695.
[1]:
Bug:
Release-Notes: Fix pagination to stop querying when there are no more results
Change-Id: Ie326f3628f5312a83bf83177a3fa5134f042b59a
M java/com/google/gerrit/index/query/PaginatingSource.java
ap...@google.com
Project: gerrit
Branch: stable-3.5
commit 1d7803586a74ab9688b32d64f9df15527fafbfde
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Thu Mar 21 19:23:05 2024
Add test paginationType NONE to query only if there are more results
If the first query to the index did not fill the full limit the caller
wants, we paginate to obtain more results. However, subsequent queries
are not needed if there are no more results from the previous query.
This add a test for the change 413358 [1], that has reintroduced the
issue fixed in change 344695.
[1]:https://gerrit-review.googlesource.com/c/gerrit/+/413358/comment/85bca522_2b3552b2/
Bug:
Release-Notes: skip
Change-Id: If578ee877587488fdf3715331bd8d23e9d86f750
M javatests/com/google/gerrit/server/query/change/FakeQueryChangesTest.java
https://gerrit-review.googlesource.com/413843
Branch: stable-3.5
commit 1d7803586a74ab9688b32d64f9df15527fafbfde
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Thu Mar 21 19:23:05 2024
Add test paginationType NONE to query only if there are more results
If the first query to the index did not fill the full limit the caller
wants, we paginate to obtain more results. However, subsequent queries
are not needed if there are no more results from the previous query.
This add a test for the change 413358 [1], that has reintroduced the
issue fixed in change 344695.
[1]:
Bug:
Release-Notes: skip
Change-Id: If578ee877587488fdf3715331bd8d23e9d86f750
M javatests/com/google/gerrit/server/query/change/FakeQueryChangesTest.java
Description
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!! *** Do not submit bugs for chrome/android and issues with your company's *** Gerrit setup here. Those issues belong in different issue trackers.
What steps will reproduce the problem?
index.maxLimit = 10public-projectWhat is the expected output?
Gerrit should make 2 queries for returning the only change C2
What do you see instead?
Gerrit makes 3 queries, where the last one is redundant because the total number of changes is 7 and 2 queries of 5 elements should have been enough.
Please provide any additional information below.
This issue was fixed with