Gerrit passwd command does not support subsections [321784728]

Feature Request

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Jan 23, 2024 11:40AM

*************************************************************************
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************

What steps will reproduce the problem?
1. Want to create a section/subsection value
2. java -jar bin/gerrit.war passwd remote.instance-2.username

What is the expected output?
Value created in secure.config within the following
[remote "instance-2"]
username = dijfdgjiofgjflifxjk

What do you see instead?
java -jar bin/gerrit.war passwd remote.instance-2.username
Exception in thread "main" java.lang.IllegalArgumentException: Invalid name 'remote.instance-2.username': expected section.key format
at com.google.gerrit.pgm.Passwd.init(Passwd.java:54)
at com.google.gerrit.pgm.Passwd.run(Passwd.java:63)
at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:62)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:252)
at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:148)
at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:93)
at Main.main(Main.java:30)

Please provide any additional information below.
Workaround: create a dummy section and edit by hand the section to the correct section/subsection

Comments

ma...@gmail.com <ma...@gmail.com> #2Jan 31, 2024 11:06AM

According to the help of this command:

$ java -jar bazel-bin/release.war passwd -h
passwd SECTION.KEY [PASSWORD] [--help (-h)] [--show-stack-trace] [--site-path (-d) VAL]

 SECTION.KEY          : Section and key separated by a dot of the password to
                        set
 PASSWORD             : Password to set
 --help (-h)          : display this help text (default: true)
 --show-stack-trace   : display stack trace on failure (default: false)
 --site-path (-d) VAL : Local directory containing site data

subsections are not yet supported. Hence marking this as a feature request.

jo...@gmail.com <jo...@gmail.com> #3Mar 20, 2024 11:27AM

Implemented on change https://gerrit-review.googlesource.com/c/gerrit/+/413562

ap...@google.com <ap...@google.com> #4Apr 11, 2024 11:18AM

Project: gerrit
Branch: master

commit a7f438cea6222d92bbcf32bbfe5ddd7f31a9defc
Author: Jose Granha <jose.granha@gmail.com>
Date: Wed Mar 20 11:23:50 2024

Add support for using subsections in passwd

Add support for the usage of both section.key as well as
section.subsection.key in the passwd command.

New format:
java -jar bin/gerrit.war passwd --help
passwd SECTION.[SUBSECTION.]KEY [PASSWORD]
SECTION.[SUBSECTION.]KEY : Section, subsection and key
separated by a dot of the password to set. Subsection
is optional

Bug:

Issue 321784728

Release-Notes: Add support for using subsections in passwd
Change-Id: I5ef94a46f1b703f08de0db6ebfd87b760c63f1d0

M Documentation/pgm-passwd.txt
M java/com/google/gerrit/pgm/Passwd.java
M java/com/google/gerrit/pgm/SetPasswd.java

https://gerrit-review.googlesource.com/413562