Bug P1
Status Update
No update yet.
Comments
ap...@google.com
Project: gerrit
Branch: master
commit c003b5127020523c3e16f8224c283fc8a4638109
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 12:32:00 2024
Deprecate review command without project argument
Searching a change by change number only can be
ambigous in case projects have been imported from
other Gerrit servers.
Log deprecation warning for review commands without
project parameter.
Bug:
Release-Notes: Deprecate review command without project argument
Change-Id: I94d4a7c1e2efb46ae3101dbac1daaa94da9cbd8b
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
https://gerrit-review.googlesource.com/404717
Branch: master
commit c003b5127020523c3e16f8224c283fc8a4638109
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 12:32:00 2024
Deprecate review command without project argument
Searching a change by change number only can be
ambigous in case projects have been imported from
other Gerrit servers.
Log deprecation warning for review commands without
project parameter.
Bug:
Release-Notes: Deprecate review command without project argument
Change-Id: I94d4a7c1e2efb46ae3101dbac1daaa94da9cbd8b
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
ap...@google.com
Project: gerrit
Branch: master
commit 91045bbbd7631075d77916860b87b4874ce677a9
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 12:54:35 2024
Fail review command if multiple changes are selected
If a change is not uniquely identified the review
command has to fail, otherwise is not possible
to determine to which change the review has been
posted to.
Bug:
Release-Notes: Fail review command if multiple changes are selected
Change-Id: Icbae6362f9915f412b1bfa7d228823fc3d32b1c7
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
https://gerrit-review.googlesource.com/404738
Branch: master
commit 91045bbbd7631075d77916860b87b4874ce677a9
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 12:54:35 2024
Fail review command if multiple changes are selected
If a change is not uniquely identified the review
command has to fail, otherwise is not possible
to determine to which change the review has been
posted to.
Bug:
Release-Notes: Fail review command if multiple changes are selected
Change-Id: Icbae6362f9915f412b1bfa7d228823fc3d32b1c7
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
ap...@google.com
Project: gerrit
Branch: master
commit 5a4993198175767287850c93f2a6247943264102
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 13:17:20 2024
Use project in review command
Making sure to use project in review command
when specified in the arguments.
Bug:
Release-Notes: Use project in review command
Change-Id: Ib991b9467a75755a3d5152000be25cb26cc7f621
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
https://gerrit-review.googlesource.com/404739
Branch: master
commit 5a4993198175767287850c93f2a6247943264102
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 25 13:17:20 2024
Use project in review command
Making sure to use project in review command
when specified in the arguments.
Bug:
Release-Notes: Use project in review command
Change-Id: Ib991b9467a75755a3d5152000be25cb26cc7f621
M java/com/google/gerrit/sshd/commands/ReviewCommand.java
so...@gmail.com Restricted+
Restricted+
Comment has been deleted.
lu...@gmail.com
This was actually a consequence of the project~changeNum.
I would say the opposite: deprecate the use of project with the -p <project> because all the other commands can simply get it from the change id.
ap...@google.com
Project: gerrit
Branch: master
commit fd2170ad69004a18bc242272949a6e60b4c38b05
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 18 12:23:24 2024
Introduce change number in secondary index
The only information contained in the index concerning
change number is the virtual id, stored in the `legacy_id_str`
field.
The virtual id is a combination of server Id + change number
(I7b9acabb).
Not having change number, but only virtual id in the index
prevents a lookup by change number for imported changes from
other servers.
This restriction doesn't allow command execution on
imported changes.
Added `changenum` in the secondary index to allow lookups
by change number.
Bug:
Release-Notes: Introduce change number in secondary index
Forward-Compatible: checked
Change-Id: If141b0b10e150736d2934ff0ef5316725f669026
M java/com/google/gerrit/server/index/change/ChangeField.java
M java/com/google/gerrit/server/index/change/ChangeSchemaDefinitions.java
M java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
https://gerrit-review.googlesource.com/403520
Branch: master
commit fd2170ad69004a18bc242272949a6e60b4c38b05
Author: Fabio Ponciroli <ponch78@gmail.com>
Date: Thu Jan 18 12:23:24 2024
Introduce change number in secondary index
The only information contained in the index concerning
change number is the virtual id, stored in the `legacy_id_str`
field.
The virtual id is a combination of server Id + change number
(I7b9acabb).
Not having change number, but only virtual id in the index
prevents a lookup by change number for imported changes from
other servers.
This restriction doesn't allow command execution on
imported changes.
Added `changenum` in the secondary index to allow lookups
by change number.
Bug:
Release-Notes: Introduce change number in secondary index
Forward-Compatible: checked
Change-Id: If141b0b10e150736d2934ff0ef5316725f669026
M java/com/google/gerrit/server/index/change/ChangeField.java
M java/com/google/gerrit/server/index/change/ChangeSchemaDefinitions.java
M java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
Description
Step to reproduce
ssh -p 29418 admin@localhost gerrit review -p <P1> -m "comment" <C1>,1Expected result
The comment is posted in the change
Observed result
The comment doesn't appear in the change C1 of project P1. A similar warning can be found in the logs:
This issue is related to