Gerrit

Change in [1] introduced x-plugin dependency; however this looks broken when multiple plugins define an ApiModule.

Currently on master there are at least two plugins that do this; the healthcheck plugin and the replication plugin via a recent change (see [2]). When I create a health check in the pull-replication plugin, that healthcheck is never registered in the dynamic set, and as such the health check is never executed.

The exact same code works in 3.9, which is no surprising given the change in [2] exists only on master (ie there are not multiple plugins that expose an ApiModule, just the healthcheck plugin).

How to reproduce the bug on master:

1. Follow the instructions in the healthcheck docs (see [3]) to create a new healthcheck in the pull-replication plugin.
2. Make sure you have a Gerrit installation with the healthcheck, replication and (your version which includes the healthcheck) pull-replication plugins installed.
3. Once gerrit starts up, query the healthcheck endpoint:

$ curl --silent 'http://localhost:8080/config/server/healthcheck~status' | tail -n 1 | jq .

4. The pull-replication healthcheck will not be present in the response.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/299472 [2] https://gerrit-review.googlesource.com/c/plugins/replication/+/400797 [3] https://gerrit.googlesource.com/plugins/healthcheck/+/refs/heads/master/src/main/resources/Documentation/extensions.md