Gerrit

Approved LC for https://gerrit-review.git.corp.google.com/c/gerrit/+/388224

Submitting this update of httpcore to 4.4.16 without the corresponding update of httpclient to 4.5.14 (https://gerrit-review.googlesource.com/c/gerrit/+/388223) was apparently not a good idea. I found this broke the in-tree build of the high-availability plugin (master branch) with the build error:

ERROR: /Users/xxxxxx/src/git/gerrit/plugins/high-availability/BUILD:10:14: Building plugins/high-availability/libhigh-availability__plugin-class.jar (105 source files) and running annotation processors (AutoAnnotationProcessor, AutoValueProcessor, AutoOneOfProcessor, AutoValueGsonAdapterFactoryProcessor) failed: (Exit 1): java failed: error executing Javac command (from target //plugins/high-availability:high-availability__plugin) external/remotejdk17_macos_aarch64/bin/java '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED' '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED' ... (remaining 19 arguments skipped)
error: cannot access NotThreadSafe
  class file for org.apache.http.annotation. NotThreadSafe not found

see

• https://gerrit-review.googlesource.com/c/plugins/high-availability/+/391474?tab=checks
• and build results here https://gerrit-ci.gerritforge.com/job/plugin-high-availability-verifier/job/74%252F391474%252F4/2/console

NotThreadSafe isn't used neither in gerrit core nor in high-availability plugin.

Reverting the httpcore update or adding the httpclient update fixes the problem.

@Youssef: which approach do you prefer ? Are we close to get LC+1 on the httpclient update or should I revert the httpcore update until this happens ?

Project: gerrit
Branch: stable-3.9
Author: Matthias Sohn <matthias.sohn@sap.com>
Link:      https://gerrit-review.googlesource.com/445161

Update org.apache.httpcomponents:httpcore to 4.4.16

Update org.apache.httpcomponents:httpcore to 4.4.16 
 
The Elasticsearch module depends on httpcore-nio:4.4.12, so this 
update can potentially fix some issues likely caused by library 
incompatibility. 
 
Bug: Issue 317782004 
Release-Notes: Update org.apache.httpcomponents:httpcore to 4.4.16 
Change-Id: Id11d70d67a2026858f0e8ee644a9f7d3f600f250 
(cherry picked from commit 9752e8fa170dd35dab8efb0b52dbad7599ee1666)