Project: gerrit
Branch: master

commit 63c2c68682def434c464c2ef6033e08fb599c808
Author: Edwin Kempin <ekempin@google.com>
Date:   Thu Apr 18 10:23:01 2024

    Block submitting changes with unresolved comments for new sites by default
   
    When initialising a new Gerrit site add a submit requirement to the
    All-Projects project that blocks change submission if there are
    unresolved comments.
   
    User Stories:
    * As a reviewer I want that changes can only be submitted when all my
      comments have been resolved.
    * As a change owner I want that submitting my change is blocked until I
      have resolved all comments, so that I do not accidentally leave some
      comments unaddressed.
   
    For sites where this behaviour is not wanted, the site administrators
    can simply remove the submit requirement.
   
    Release-Notes: Submitting changes with unresolved comments is blocked for new sites by default
    Bug: Issue 317351858
    Change-Id: I1e5688701080d2ce7fe44970cfbf1215e285e80f
    Signed-off-by: Edwin Kempin <ekempin@google.com>

M       java/com/google/gerrit/server/schema/AllProjectsCreator.java
M       java/com/google/gerrit/server/schema/AllProjectsInput.java
M       java/com/google/gerrit/server/schema/testing/AllProjectsCreatorTestUtil.java
A       javatests/com/google/gerrit/acceptance/api/change/DefaultSubmitRequirementsIT.java
M       javatests/com/google/gerrit/acceptance/api/change/SubmitRequirementIT.java
M       javatests/com/google/gerrit/acceptance/api/project/SubmitRequirementsAPIIT.java
M       javatests/com/google/gerrit/acceptance/server/project/OnStoreSubmitRequirementResultModifierIT.java
M       javatests/com/google/gerrit/acceptance/server/project/SubmitRequirementsEvaluatorIT.java
M       javatests/com/google/gerrit/server/schema/AllProjectsCreatorTest.java

https://gerrit-review.googlesource.com/421137