Account chip for Author and Committer does not show correct email on hover [315957653]

Fixed

Bug

Status Update

No update yet.

Description

ya...@linaro.org

created issue #1

Dec 12, 2023 06:17PM

What steps will reproduce the problem?
1. Upload a change which has author and committer email as non-primary user email (secondary email)
2. On hovering over the account chip for author or committer, primary email is displayed

What is the expected output?
On hovering over the account chip, the committer/author email (secondary email) should be displayed

What do you see instead?
Primary email is shown instead

Please provide any additional information below.
This was not an issue in stable-3.5, this most likely got introduced while converting from polymer to lit

Screenshot 2023-12-12 at 11.43.58 PM.png

133 KB

View

Download

Screenshot 2023-12-12 at 11.45.38 PM.png

141 KB

View

Download

Comments

ya...@linaro.org <ya...@linaro.org> Dec 14, 2023 09:10AM

Assigned to ya...@linaro.org.

ap...@google.com <ap...@google.com> #2Dec 18, 2023 03:22PM

Project: gerrit
Branch: master

commit 744b4761068c8d74037e2a0bed90e30d36381d7d
Author: Yash Chaturvedi <yash.chaturvedi@linaro.org>
Date: Thu Dec 14 14:42:22 2023

Fix account hover-card bug to show correct email for Author & Committer

In cases where a secondary email is used as the author or committer
email, the email displayed in account hover-card was being overridden by
primary email from the fetched account details. Fill only the missing
details of the account to fix the issue.

Bug:

Issue 315957653

Change-Id: If79d199d2b3d34071cc5c258c03817d211f0ea8b
Release-Notes: account-chip hover-card shows correct email for author and committer

M polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.ts

https://gerrit-review.googlesource.com/397979

ya...@linaro.org <ya...@linaro.org> Dec 18, 2023 03:34PM

Marked as fixed.