Verified
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: gerrit
Branch: stable-3.5
commit e56d2c66234225094a2b322b8e6b606ad42598b8
Author: Yash Chaturvedi <yash.chaturvedi@linaro.org>
Date: Tue Oct 10 16:39:17 2023
Fix bug where changing preferred email results in duplicate emails
While changing preferred email, the client-side cache is incorrectly
updated, resulting in duplicate emails in the cache. Fix the issue by
updating the relevant logic.
Bug: Issue 304335624
Release-Notes: Changing preferred email does not result in duplicate emails
Change-Id: Ifea0d2a91426acc27b8b89720b39c858f859f31e
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.js
https://gerrit-review.googlesource.com/388914
Branch: stable-3.5
commit e56d2c66234225094a2b322b8e6b606ad42598b8
Author: Yash Chaturvedi <yash.chaturvedi@linaro.org>
Date: Tue Oct 10 16:39:17 2023
Fix bug where changing preferred email results in duplicate emails
While changing preferred email, the client-side cache is incorrectly
updated, resulting in duplicate emails in the cache. Fix the issue by
updating the relevant logic.
Bug:
Release-Notes: Changing preferred email does not result in duplicate emails
Change-Id: Ifea0d2a91426acc27b8b89720b39c858f859f31e
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.ts
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.js
Description
1. Navigate to settings page
2. Add two emails to the account
3. Change the preferred email
4. Navigate to some other page (e.g. change dashboard) without refreshing the page
5. Navigate back to the settings page and observe duplicate emails
What is the expected output?
The email list contains distinct emails with the correct preferred email set.
What do you see instead?
The email list contains duplicate emails (the one set to preferred)
Please provide any additional information below.
Introduced By: 88632: Add account registration dialog to PolyGerrit |