Fixed
Status Update
Comments
lu...@gmail.com <lu...@gmail.com> #2
da...@gmail.com <da...@gmail.com>
lu...@gmail.com <lu...@gmail.com> #3
As requested from Maintainers: moving destination branch from "master" to "stable-3.6" as this is the oldest supported version with this bug
ap...@google.com <ap...@google.com> #4
Project: gerrit
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug: Issue 290641654
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
https://gerrit-review.googlesource.com/379003
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug:
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
Description
STR
Expected output
Login should succeed, even if the Non-existent-header is not present. The display name should not be set.
Actual output
Login fails with NPE
This has been introduced by Change 94918 because of the lack of null check. This can catch Gerrit admins unawares as they could update the plugin and not notice that
httpDisplaynameHeader
should not be configured anymore.