Fixed
Status Update
No update yet.
Comments
br...@google.com
ap...@google.com
Project: gerrit
Branch: master
commit eb803454ac3cc9ef0d30b751ae8d8fcc07831977
Author: Ben Rohlfs <brohlfs@google.com>
Date: Mon Sep 04 13:04:27 2023
Fix admin links that contain the base URL twice
Change 137551 has introduced the concept of `noBaseUrl` admin links,
but in a change comment it was claimed: "The idea is for the existence
of `noBaseUrl` to be as short-lived as possible. Ideally by the end of
the week, but we'll see." Well, a couple of weeks have passed since
2017, and in the meantime the hard coded URLs were indeed fixed to
include the base URL. So there is no need to distinguish between admin
links with and without base URL anymore.
Release-Notes: Fix admin links with duplicate base URLs.
Bug:
Change-Id: I92e8d77d776662f012f05afb6095958e5441568c
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts
M polygerrit-ui/app/models/views/admin.ts
https://gerrit-review.googlesource.com/385094
Branch: master
commit eb803454ac3cc9ef0d30b751ae8d8fcc07831977
Author: Ben Rohlfs <brohlfs@google.com>
Date: Mon Sep 04 13:04:27 2023
Fix admin links that contain the base URL twice
Change 137551 has introduced the concept of `noBaseUrl` admin links,
but in a change comment it was claimed: "The idea is for the existence
of `noBaseUrl` to be as short-lived as possible. Ideally by the end of
the week, but we'll see." Well, a couple of weeks have passed since
2017, and in the meantime the hard coded URLs were indeed fixed to
include the base URL. So there is no need to distinguish between admin
links with and without base URL anymore.
Release-Notes: Fix admin links with duplicate base URLs.
Bug:
Change-Id: I92e8d77d776662f012f05afb6095958e5441568c
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts
M polygerrit-ui/app/models/views/admin.ts
br...@google.com
ap...@google.com
Project: gerrit
Branch: stable-3.8
commit 4f126715f846b5c7e8c4150dfed9db3a8eb68c51
Author: Ben Rohlfs <brohlfs@google.com>
Date: Mon Sep 04 13:04:27 2023
Fix admin links that contain the base URL twice
Change 137551 has introduced the concept of `noBaseUrl` admin links,
but in a change comment it was claimed: "The idea is for the existence
of `noBaseUrl` to be as short-lived as possible. Ideally by the end of
the week, but we'll see." Well, a couple of weeks have passed since
2017, and in the meantime the hard coded URLs were indeed fixed to
include the base URL. So there is no need to distinguish between admin
links with and without base URL anymore.
Release-Notes: Fix admin links with duplicate base URLs.
Bug:
Change-Id: I92e8d77d776662f012f05afb6095958e5441568c
(cherry picked from commit eb803454ac3cc9ef0d30b751ae8d8fcc07831977)
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts
M polygerrit-ui/app/models/views/admin.ts
https://gerrit-review.googlesource.com/385134
Branch: stable-3.8
commit 4f126715f846b5c7e8c4150dfed9db3a8eb68c51
Author: Ben Rohlfs <brohlfs@google.com>
Date: Mon Sep 04 13:04:27 2023
Fix admin links that contain the base URL twice
Change 137551 has introduced the concept of `noBaseUrl` admin links,
but in a change comment it was claimed: "The idea is for the existence
of `noBaseUrl` to be as short-lived as possible. Ideally by the end of
the week, but we'll see." Well, a couple of weeks have passed since
2017, and in the meantime the hard coded URLs were indeed fixed to
include the base URL. So there is no need to distinguish between admin
links with and without base URL anymore.
Release-Notes: Fix admin links with duplicate base URLs.
Bug:
Change-Id: I92e8d77d776662f012f05afb6095958e5441568c
(cherry picked from commit eb803454ac3cc9ef0d30b751ae8d8fcc07831977)
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts
M polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view_test.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header_test.ts
M polygerrit-ui/app/models/views/admin.ts
Description
What steps will reproduce the problem?
1. Configure a context path in gerrit.config (e.g.
2. Navigate to the Admin View (
3. Click one of the links in the left navigation area (Repositories/Groups/Plugins)
What is the expected output?
Become redirected to f.i.
Note the single /gerrit/ context path.
What do you see instead?
Become redirected to f.i.
Note the double /gerrit/ context path.
What is the output of the JS console log (if applicable)?
404's as the browser attempts to resolve incorrect paths.
What is the performance record (see
N/A
Please provide any additional information below.