Bug P3
Status Update
Comments
ap...@google.com <ap...@google.com> #2
sy...@gmail.com <sy...@gmail.com> #3
As requested from Maintainers: moving destination branch from "master" to "stable-3.6" as this is the oldest supported version with this bug
sy...@gmail.com <sy...@gmail.com> #4
Project: gerrit
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug: Issue 290641654
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
https://gerrit-review.googlesource.com/379003
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug:
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
ap...@google.com <ap...@google.com> #5
Project: gerrit
Branch: stable-3.6
commit 29b4af9ee55ae16064b38db9c86255ac037d27e9
Author: Antonio Barone <syntonyze@gmail.com>
Date: Thu Sep 21 20:14:46 2023
Avoid NPE when deleting single ref
Change I8e19d756db fixed a bug where an NPE was thrown during the
deletion of multiple refs if one of them didn't exist, or possibly
already removed by a concurrent caller.
The `deleteMultipleRefs()` method however, falls back to calling the
`deleteSingleRef()` method, which also suffers from the same issue.
Fix the `deleteSingleRef()` method to account for unexisting refs, so
that a concurrent execution from another caller does not cause an NPE.
Release-Notes: Avoid NullPointerException when deleting a single ref
Bug: Issue 291102119
Change-Id: Ibe79290f4eb7332cc22e72c906fe5f60bedbcca6
M java/com/google/gerrit/server/restapi/project/DeleteRef.java
https://gerrit-review.googlesource.com/387103
Branch: stable-3.6
commit 29b4af9ee55ae16064b38db9c86255ac037d27e9
Author: Antonio Barone <syntonyze@gmail.com>
Date: Thu Sep 21 20:14:46 2023
Avoid NPE when deleting single ref
Change I8e19d756db fixed a bug where an NPE was thrown during the
deletion of multiple refs if one of them didn't exist, or possibly
already removed by a concurrent caller.
The `deleteMultipleRefs()` method however, falls back to calling the
`deleteSingleRef()` method, which also suffers from the same issue.
Fix the `deleteSingleRef()` method to account for unexisting refs, so
that a concurrent execution from another caller does not cause an NPE.
Release-Notes: Avoid NullPointerException when deleting a single ref
Bug:
Change-Id: Ibe79290f4eb7332cc22e72c906fe5f60bedbcca6
M java/com/google/gerrit/server/restapi/project/DeleteRef.java
Description
*** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!
*** Do not submit bugs for chrome/android and issues with your company's
*** Gerrit setup here. Those issues belong in different issue trackers.
*************************************************************************
What steps will reproduce the problem?
1. Setup two Gerrit nodes with pull-replication
2. Run gatling tests for each node at the same time
What is the expected output?
All gatling test are successful
What do you see instead?
For some small number of tag deletions(1 out of 10 000) Gerrit returns 500
Please provide any additional information below.
In the logs I can see NullPointerException from:
This is a classic concurrency issue where in the middle of the ref delete pull-replication delete it as well.
Another thing is why we read ref twice[1] and [2] instead of reusing the variable.
1.
2.