Fixed
Status Update
No update yet.
Comments
lu...@gmail.com
ap...@google.com
Project: gerrit
Branch: stable-3.8
commit cfb981057f878b19a91ee61334e4a54e62fbf424
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Wed Aug 02 14:01:06 2023
loginUrl and loginText are hardcoded in the UI
Gerrit UI ignored the settings in the auth section of the
configuration [1].
In particular auth.loginUrl [2] should be used if present and
auth.type is set to HTTP or HTTP_LDAP.
Also auth.loginText [3] should be used if auth.loginUrl is set.
[1]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth
[2]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth.loginUrl
[3]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth.loginText
Bug:
Release-Notes: Fix loginUrl and loginText hardcoded in the UI
Change-Id: I405259438edbfe582feef677a928d2cce07d2c28
M polygerrit-ui/app/elements/core/gr-error-dialog/gr-error-dialog.ts
M polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
M polygerrit-ui/app/elements/gr-app-element.ts
M polygerrit-ui/app/elements/gr-app_test.ts
M polygerrit-ui/app/utils/url-util.ts
M polygerrit-ui/app/utils/url-util_test.ts
https://gerrit-review.googlesource.com/381534
Branch: stable-3.8
commit cfb981057f878b19a91ee61334e4a54e62fbf424
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Wed Aug 02 14:01:06 2023
loginUrl and loginText are hardcoded in the UI
Gerrit UI ignored the settings in the auth section of the
configuration [1].
In particular auth.loginUrl [2] should be used if present and
auth.type is set to HTTP or HTTP_LDAP.
Also auth.loginText [3] should be used if auth.loginUrl is set.
[1]:
[2]:
[3]:
Bug:
Release-Notes: Fix loginUrl and loginText hardcoded in the UI
Change-Id: I405259438edbfe582feef677a928d2cce07d2c28
M polygerrit-ui/app/elements/core/gr-error-dialog/gr-error-dialog.ts
M polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
M polygerrit-ui/app/elements/gr-app-element.ts
M polygerrit-ui/app/elements/gr-app_test.ts
M polygerrit-ui/app/utils/url-util.ts
M polygerrit-ui/app/utils/url-util_test.ts
br...@google.com
ap...@google.com
Project: gerrit
Branch: stable-3.6
commit eaab2484e5e454372dc932c412456635497783c1
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Mon Aug 07 15:02:41 2023
loginUrl and loginText are hardcoded in the UI
Gerrit UI ignored the settings in the auth section of the
configuration [1].
In particular auth.loginUrl [2] should be used if present and
auth.type is set to HTTP or HTTP_LDAP.
Also auth.loginText [3] should be used if auth.loginUrl is set.
This change backports change 381534 to stable-3.6. We didn't cherry-pick because the code changes significantly and had many conflicts.
[1]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth
[2]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth.loginUrl
[3]:https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth.loginText
Bug:
Release-Notes: Fix loginUrl and loginText hardcoded in the UI
Change-Id: I742ace66bb4b95c9a38d7461a76d74e08cfc68e7
M polygerrit-ui/app/elements/core/gr-error-dialog/gr-error-dialog.ts
M polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
M polygerrit-ui/app/elements/gr-app-element.ts
M polygerrit-ui/app/utils/url-util.ts
M polygerrit-ui/app/utils/url-util_test.ts
https://gerrit-review.googlesource.com/382075
Branch: stable-3.6
commit eaab2484e5e454372dc932c412456635497783c1
Author: Diego Zambelli Sessona <diego.sessona@gmail.com>
Date: Mon Aug 07 15:02:41 2023
loginUrl and loginText are hardcoded in the UI
Gerrit UI ignored the settings in the auth section of the
configuration [1].
In particular auth.loginUrl [2] should be used if present and
auth.type is set to HTTP or HTTP_LDAP.
Also auth.loginText [3] should be used if auth.loginUrl is set.
This change backports change 381534 to stable-3.6. We didn't cherry-pick because the code changes significantly and had many conflicts.
[1]:
[2]:
[3]:
Bug:
Release-Notes: Fix loginUrl and loginText hardcoded in the UI
Change-Id: I742ace66bb4b95c9a38d7461a76d74e08cfc68e7
M polygerrit-ui/app/elements/core/gr-error-dialog/gr-error-dialog.ts
M polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
M polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
M polygerrit-ui/app/elements/gr-app-element.ts
M polygerrit-ui/app/utils/url-util.ts
M polygerrit-ui/app/utils/url-util_test.ts
da...@gmail.com
Please delete me in group i want to stop using gerrit
On Tue, Aug 15, 2023 at 4:09 PM <buganizer-system@google.com> wrote:
On Tue, Aug 15, 2023 at 4:09 PM <buganizer-system@google.com> wrote:
Description
=======
I am running locally the following topology:
- Gerrit v3.6 with HTTP auth and loginUrl pointing to "/mycustomLogin"
When I land in the homepage "localhost:8080" and I press the "Sign in" link I am expecting to point to "/mycustomLogin"
I followed the Gerrit documentation [1] and I defined in "etc/gerrit.config":
[auth]
...
loginUrl = /mycutomLogin
- What I see instead is that the link points to "/login"
Problem
=======
The value of "loginUrl" and "loginText" is ignored and the "Sign in" link is hardcoded to "/login", when the auth type is HTTP or HTTP_LDAP
I looked into the code[2] and It looks like:
- protocol, host and port are derived from the canonical path
- the first part of path is hardcoded to "/login/"
- the second part of the path is derived from the browser
Note: auth.loginText is ignored to and the text is harcoded in the UI.
Links:
[1]:
[2]: