Status Update
Comments
fa...@gmail.com <fa...@gmail.com> #2
[Empty comment from Monorail migration]
lu...@gmail.com <lu...@gmail.com> #3
The main features are shown on the main index of the home page. Should the about page include the same information that is there, or be more detailed?
lu...@gmail.com <lu...@gmail.com> #4
I would say more details. Alternatively we could just rename it to "Project History" and move it to a less prominent place.
lu...@gmail.com <lu...@gmail.com> #5
[Monorail components: Homepage]
lu...@gmail.com <lu...@gmail.com> #6
[Monorail components: Documentation]
lu...@gmail.com <lu...@gmail.com> #7
[Monorail components: -docs]
fa...@gmail.com <fa...@gmail.com> #8
[Empty comment from Monorail migration]
lu...@gmail.com <lu...@gmail.com> #11
This was already reported in the https://crbug.com/gerrit/11811 . Closing this one as duplicate.
is...@google.com <is...@google.com> #12
Edits were made to reflect the following in Monorail: auto-CCs.
Description
Affected Version: Gerrit v3.1.x or later
What steps will reproduce the problem?
1. Pick a change and go on the change detail page
2. Expand a diff
3. Select a portion of a line
4. Press 'c' to comment
What is the expected output?
* The portion of the line selected is highlighted
* The comment is relative to the selected portion
What do you see instead?
* No highlighting
* The comment is related to the whole line
What is the output of the JS console log (if applicable)?
N/A
What is the performance record (seehttps://developers.google.com/web/tools
/chrome-devtools/evaluate-performance/reference#record)(if applicable)?
N/A
Please provide any additional information below.
The problem is on:
The fallback logic isn't working on Safari, as the document.getSelection() won't return the correct selection and it will be later discarded altogether.
The functionality was fully working on Gerrit v3.0.x, hence this is a functional regression.
Attached a screencast showing the issue.
The issue has been tested with Safari Version 14.0.1 (16610.2.11.51.8) and Safari Version 14.0.2 (16610.3.7.1.9)