In Progress
Status Update
No update yet.
Comments
na...@oss.qualcomm.com
ap...@google.com
Project: gerrit
Branch: master
Author: Daniele Sassoli <
Link:
Add new permission to allow posting reviews
Expand for full commit details
Add new permission to allow posting reviews
This is done, mainly, with the intention of allowing Gerrit admins to prevent users from posting reviews if they are found posting spam
content.
Bug: Issue 391666234
Release-Notes: Add new permission to allow posting reviews
Forward-Compatible: checked
Change-Id: I91755296aef3917f99760d0451f7c0b376825540
Files:
- M
Documentation/access-control.txt - M
java/com/google/gerrit/entities/Permission.java - M
java/com/google/gerrit/server/permissions/ChangeControl.java - M
java/com/google/gerrit/server/permissions/ChangePermission.java - M
java/com/google/gerrit/server/permissions/DefaultPermissionMappings.java - M
java/com/google/gerrit/server/restapi/change/PostReview.java - M
java/com/google/gerrit/server/schema/AllProjectsCreator.java - M
java/com/google/gerrit/server/schema/testing/AllProjectsCreatorTestUtil.java - M
javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java - M
polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section_test.ts - M
polygerrit-ui/app/utils/access-util.ts
Hash: 00be0e222f7a22c570fc63b1662a32b06ad78a21
Date: Mon Jan 27 18:35:36 2025
ap...@google.com
Project: gerrit
Branch: master
Author: Edwin Kempin <
Link:
Revert "Add new permission to allow posting reviews"
Expand for full commit details
Revert "Add new permission to allow posting reviews"
This reverts commit 00be0e222f7a22c570fc63b1662a32b06ad78a21.
Reason for revert: This change breaks posting reviews on
existing sites where the new 'Review' permission is not assigned.
For Google we need time to write and run a migration that assigns
this permission on all hosts [1] and to adapt our site creation [2].
[1] https://issues.gerritcodereview.com/issues/393995222
[2] https://issues.gerritcodereview.com/issues/393991559
Change-Id: I0876a4715a507e990aa23cce95c4d347a7e66173
Bug: Issue 391666234
Forward-Compatible: checked
Files:
- M
Documentation/access-control.txt - M
java/com/google/gerrit/entities/Permission.java - M
java/com/google/gerrit/server/permissions/ChangeControl.java - M
java/com/google/gerrit/server/permissions/ChangePermission.java - M
java/com/google/gerrit/server/permissions/DefaultPermissionMappings.java - M
java/com/google/gerrit/server/restapi/change/PostReview.java - M
java/com/google/gerrit/server/schema/AllProjectsCreator.java - M
java/com/google/gerrit/server/schema/testing/AllProjectsCreatorTestUtil.java - M
javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java - M
polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section_test.ts - M
polygerrit-ui/app/utils/access-util.ts
Hash: 3620c47c03026e4d5ceaad737c17320999337af6
Date: Mon Feb 03 01:01:12 2025
Description
# "As a [user|reviewer|change-owner|project-owner|admin] I want to ... so that ..."
# Example: "As a change owner I want to be able to group changes so that they are submitted together."
As a Gerrit Community Manager
I want to be able to block users from posting comments
So that we can reduce the levels of spam on googlesource.
This will enable the second part of the work describe in, Issue:391750819