Fixed
Status Update
Comments
ek...@google.com <ek...@google.com> #2
Our build dependency to asm is defined here:
https://source.corp.google.com/piper///depot/google3/third_party/java_src/gerritcodereview/gerrit/libmap.bzl;l=74-76
The asm metadata says that the "closest_version" is "ASM_9_7":
https://source.corp.google.com/piper///depot/google3/third_party/java/asm/METADATA;rcl=680065813;l=16
Not sure what exactly "closest_version" means, but it sounds like upgrading upstream Gerrit to asm 9.7 should be fine. Hence approving Library-Compliance onhttps://gerrit-review.googlesource.com/c/gerrit/+/433298 . Especially since no code changes are required, this should be safe.
The asm metadata says that the "closest_version" is "ASM_9_7":
Not sure what exactly "closest_version" means, but it sounds like upgrading upstream Gerrit to asm 9.7 should be fine. Hence approving Library-Compliance on
ap...@google.com <ap...@google.com> #3
Project: gerrit
Branch: master
Author: David Ostrovsky <
Link:
Bump asm version to 9.7
Expand for full commit details
Bump asm version to 9.7
This update is needed for Java 21, 22 and 23 suppport.
Bug: Issue 355451185
Release-Notes: Update asm version to 9.7
Change-Id: I87c89d78eed444ef5544fe344c90d11bbaba8ccb
Files:
- M
tools/deps.bzl
Hash: 2345d5f771e2a46cf756eb04d52122d43cb8cf62
Date: Sun Jul 14 14:53:12 2024
ap...@google.com <ap...@google.com> #4
Project: gerrit
Branch: stable-3.11
Author: David Ostrovsky <
Link:
Bump asm version to 9.7
Expand for full commit details
Bump asm version to 9.7
This update is needed for Java 21, 22 and 23 suppport.
Bug: Issue 355451185
Release-Notes: Update asm version to 9.7
Change-Id: I87c89d78eed444ef5544fe344c90d11bbaba8ccb
(cherry picked from commit 2345d5f771e2a46cf756eb04d52122d43cb8cf62)
Files:
- M
tools/deps.bzl
Hash: 7472ee7780e587360b9427f8e54e7bba304c4af5
Date: Sun Jul 14 14:53:12 2024
ju...@gmail.com <ju...@gmail.com> #5
Comment has been deleted.
Description