Fixed
Status Update
Comments
th...@yahoo.com <th...@yahoo.com> #2
[Empty comment from Monorail migration]
br...@google.com <br...@google.com> #3
The main features are shown on the main index of the home page. Should the about page include the same information that is there, or be more detailed?
mi...@google.com <mi...@google.com>
th...@yahoo.com <th...@yahoo.com> #4
I would say more details. Alternatively we could just rename it to "Project History" and move it to a less prominent place.
th...@yahoo.com <th...@yahoo.com>
ap...@google.com <ap...@google.com> #6
[Monorail components: Documentation]
ap...@google.com <ap...@google.com> #7
[Monorail components: -docs]
ap...@google.com <ap...@google.com> #8
[Empty comment from Monorail migration]
ap...@google.com <ap...@google.com> #9
Project: gerrit
Branch: stable-3.10
commit a9514d93f89a8b25962a09682fc7798620c23a7a
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
https://gerrit-review.googlesource.com/421280
Branch: stable-3.10
commit a9514d93f89a8b25962a09682fc7798620c23a7a
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
ap...@google.com <ap...@google.com> #10
Project: gerrit
Branch: stable-3.8
commit ccedf64fe81829af4e907f1ee58cb7e198a8a9e0
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
https://gerrit-review.googlesource.com/421282
Branch: stable-3.8
commit ccedf64fe81829af4e907f1ee58cb7e198a8a9e0
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
ap...@google.com <ap...@google.com> #11
Project: gerrit
Branch: stable-3.9
commit 86be8e24bef2fdf474239c6eee747ffae6646d4b
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
https://gerrit-review.googlesource.com/421281
Branch: stable-3.9
commit 86be8e24bef2fdf474239c6eee747ffae6646d4b
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
ap...@google.com <ap...@google.com> #12
Project: gerrit
Branch: stable-3.8
commit ccedf64fe81829af4e907f1ee58cb7e198a8a9e0
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
https://gerrit-review.googlesource.com/421282
Branch: stable-3.8
commit ccedf64fe81829af4e907f1ee58cb7e198a8a9e0
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Thu Apr 18 20:14:18 2024
Remove reload-diff-preference unneeded event
We don't need to trigger this as the model already updates the diffPref
config and triggers a refresh.
Release-Notes: Remove reload-diff-preference unneeded event
Bug: 335613081
Change-Id: I2413cee2169d7347c7354af6131db28411197251
(cherry picked from commit e81286c3421227ea1e2636c9cd97e8fd349130c6)
M polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
M polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.ts
M polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
ap...@google.com <ap...@google.com> #13
Project: gerrit
Branch: master
commit 6915b8aa40620176313ec3b55aef90e28a3e6936
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
https://gerrit-review.googlesource.com/421279
Branch: master
commit 6915b8aa40620176313ec3b55aef90e28a3e6936
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
ap...@google.com <ap...@google.com> #14
Project: gerrit
Branch: stable-3.10
commit 8d839163c2b09c6ecd04e239df72023d048574a9
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
https://gerrit-review.googlesource.com/421877
Branch: stable-3.10
commit 8d839163c2b09c6ecd04e239df72023d048574a9
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
ap...@google.com <ap...@google.com> #15
Project: gerrit
Branch: stable-3.8
commit c2451865aadcefac4b457f60e28752c62f6637db
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
https://gerrit-review.googlesource.com/421917
Branch: stable-3.8
commit c2451865aadcefac4b457f60e28752c62f6637db
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
ap...@google.com <ap...@google.com> #16
Project: gerrit
Branch: stable-3.9
commit b1c11af64a57601426c09bcace181ed838388eed
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
https://gerrit-review.googlesource.com/421897
Branch: stable-3.9
commit b1c11af64a57601426c09bcace181ed838388eed
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
ap...@google.com <ap...@google.com> #17
Project: gerrit
Branch: stable-3.8
commit c2451865aadcefac4b457f60e28752c62f6637db
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
https://gerrit-review.googlesource.com/421917
Branch: stable-3.8
commit c2451865aadcefac4b457f60e28752c62f6637db
Author: Paladox none <thomasmulhall410@yahoo.com>
Date: Sat Apr 20 21:20:41 2024
Fix clearing cache in gr-rest-api
We include the base url in urlWithParams so we have to do the same
inside gr-rest-api by calling getBaseUrl().
Also clear cache in savePreferences().
Release-Notes: Fix clearing cache in gr-rest-api
Bug: 335613081
Change-Id: Ic0fb6af3316c8cd77bcaa64b802cd777cff339d7
(cherry picked from commit 6915b8aa40620176313ec3b55aef90e28a3e6936)
M polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts
M polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
Description
What steps will reproduce the problem?
1. Locally create a change and edit a file and publish
2. Go to the diff and then click on the diff preference setting icon
3. Change fit to screen on and off
What is the expected output?
It gets set off and when setting it on that it takes effect.
What do you see instead?
When you try to switch it back on, it doesn't take immediate effect and in the diff-preference it shows the save button even tho you saved it.
What is the output of the JS console log (if applicable)?
What is the performance record (see
Please provide any additional information below.
I can't seem to reprodice on gerrit-review but i can reproduce locally.
From what i see originalDiffPrefs doesn't get the saved value.