Bug P2
Status Update
Comments
ku...@gmail.com <ku...@gmail.com> #2
ku...@gmail.com <ku...@gmail.com> #3
As requested from Maintainers: moving destination branch from "master" to "stable-3.6" as this is the oldest supported version with this bug
ap...@google.com <ap...@google.com> #4
Project: gerrit
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug: Issue 290641654
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
https://gerrit-review.googlesource.com/379003
Branch: stable-3.6
commit c81232ad71adc60275608b54b369b4346d950abe
Author: Paweł Kurek <kurek.zxc@gmail.com>
Date: Tue Jul 11 09:30:13 2023
Fix CreateAccessChange ignoring provided review message
Fix API endpoint 'CreateAccessChange' '/projects/*/access:review'
not hounouring 'message' field provided via 'ProjectAccessInput' object despite setting it.
Add condition to check if message is provided then use it instead of default 'Review access change'
Bug:
Release-Notes: Fix bug in API '/projects/*/access:review' ignoring 'message' field
Change-Id: I807d9989e23c68a762966ba7b60d6644605c739f
M java/com/google/gerrit/server/restapi/project/CreateAccessChange.java
A javatests/com/google/gerrit/acceptance/api/project/AccessReviewIT.java
Description
I've performed some tests on 3.6.2 and master and reproduced this bug.
So I've created a fix for that and wrote some acceptance test as they were missing.
This is my first contribution to Gerrit so any advice is welcomed.