Verified
Status Update
Comments
lu...@gmail.com <lu...@gmail.com> #2
fa...@gmail.com <fa...@gmail.com> #3
Yo
ap...@google.com <ap...@google.com> #4
Project: gerrit
Branch: stable-3.6
commit cdf4972b680840aa86104149f3638170a2ccde49
Author: Marcin Czech <maczech@gmail.com>
Date: Fri Jun 30 22:09:01 2023
Preserve refs order in the GitBatchRefUpdateEvent event
Change I79eefbee introduced the concept of the single event
representing batch ref update. However this new event doesn't
preserve original order of the updated refs. This impacts event
consumers behaviour and can cause failures. For example if meta
ref is processed before patchset ref indexing operation will
fail because of the missing patchset.
To make sure that refs order is preserved and backward compatibility
is kept use LinkedHashSet instead of HashSet.
Bug: Issue 289321387
Release-Notes: Preserve refs order in the GitBatchRefUpdateEvent event
Change-Id: I198d60bb172edbccce739054da93e9f014c02c2b
M java/com/google/gerrit/server/extensions/events/GitReferenceUpdated.java
M javatests/com/google/gerrit/server/extensions/events/GitReferenceUpdatedTest.java
https://gerrit-review.googlesource.com/378558
Branch: stable-3.6
commit cdf4972b680840aa86104149f3638170a2ccde49
Author: Marcin Czech <maczech@gmail.com>
Date: Fri Jun 30 22:09:01 2023
Preserve refs order in the GitBatchRefUpdateEvent event
Change I79eefbee introduced the concept of the single event
representing batch ref update. However this new event doesn't
preserve original order of the updated refs. This impacts event
consumers behaviour and can cause failures. For example if meta
ref is processed before patchset ref indexing operation will
fail because of the missing patchset.
To make sure that refs order is preserved and backward compatibility
is kept use LinkedHashSet instead of HashSet.
Bug:
Release-Notes: Preserve refs order in the GitBatchRefUpdateEvent event
Change-Id: I198d60bb172edbccce739054da93e9f014c02c2b
M java/com/google/gerrit/server/extensions/events/GitReferenceUpdated.java
M javatests/com/google/gerrit/server/extensions/events/GitReferenceUpdatedTest.java
Description